From 0620b5eda03cd124d4bd743660cb376b0d75a0a3 Mon Sep 17 00:00:00 2001
From: "Shahar Or (mightyiam)" <mightyiampresence@gmail.com>
Date: Sun, 17 May 2020 17:19:33 +0700
Subject: [PATCH] ux(typescript): do not redeclare Element.setAttribute(NS)

BREAKING CHANGE: Types exported by this package have re-declared
the global `Element.setAttribute` and `Element.setAttributeNS` to
accept `number` and `boolean` for the `value` parameter. This
change removes that re-declaration and thus the only valid value is
`string`. If your code provides `number` and/or `boolean`, then it
may now fail to compile.

Fixes #615.
---
 commitlint.config.json    |  1 +
 src/modules/attributes.ts | 16 ++++++++--------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/commitlint.config.json b/commitlint.config.json
index 3b01831..72071db 100644
--- a/commitlint.config.json
+++ b/commitlint.config.json
@@ -21,6 +21,7 @@
     "scope-empty": [2, "never"],
     "scope-enum": [2, "always", [
       "commitlint",
+      "typescript",
       "vscode"
     ]]
   }
diff --git a/src/modules/attributes.ts b/src/modules/attributes.ts
index 5a277ba..18b1ebd 100755
--- a/src/modules/attributes.ts
+++ b/src/modules/attributes.ts
@@ -1,14 +1,6 @@
 import { VNode, VNodeData } from '../vnode'
 import { Module } from './module'
 
-// because those in TypeScript are too restrictive: https://github.com/Microsoft/TSJS-lib-generator/pull/237
-declare global {
-  interface Element {
-    setAttribute(name: string, value: string | number | boolean): void
-    setAttributeNS(namespaceURI: string, qualifiedName: string, value: string | number | boolean): void
-  }
-}
-
 export type Attrs = Record<string, string | number | boolean>
 
 const xlinkNS = 'http://www.w3.org/1999/xlink'
@@ -37,6 +29,14 @@ function updateAttrs (oldVnode: VNode, vnode: VNode): void {
       } else if (cur === false) {
         elm.removeAttribute(key)
       } else {
+        /**
+         * The following `setAttribute` calls pass type checking
+         * with the `value` parameter possibly a `number` due to
+         * the import of `latest-snabbdom-release` in
+         * `src/benchmark/core.ts`, which re-declares `setAttribute`.
+         * For background, read
+         * https://github.com/snabbdom/snabbdom/issues/615
+         */
         if (key.charCodeAt(0) !== xChar) {
           elm.setAttribute(key, cur)
         } else if (key.charCodeAt(3) === colonChar) {