From 96e4ed2d497d70d58ab3b8a30f29d96781ad544f Mon Sep 17 00:00:00 2001 From: lyxell Date: Sat, 31 Jul 2021 02:52:59 +0200 Subject: [PATCH] Simplify code using Map::computeIfAbsent Signed-off-by: lyxell --- .../src/main/java/org/redisson/remote/BaseRemoteProxy.java | 7 +------ .../main/java/org/redisson/remote/BaseRemoteService.java | 7 +------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/redisson/src/main/java/org/redisson/remote/BaseRemoteProxy.java b/redisson/src/main/java/org/redisson/remote/BaseRemoteProxy.java index c472b907a..9e22309ae 100644 --- a/redisson/src/main/java/org/redisson/remote/BaseRemoteProxy.java +++ b/redisson/src/main/java/org/redisson/remote/BaseRemoteProxy.java @@ -67,12 +67,7 @@ public abstract class BaseRemoteProxy { private final Map, String> requestQueueNameCache = new ConcurrentHashMap<>(); public String getRequestQueueName(Class remoteInterface) { - String str = requestQueueNameCache.get(remoteInterface); - if (str == null) { - str = "{" + name + ":" + remoteInterface.getName() + "}"; - requestQueueNameCache.put(remoteInterface, str); - } - return str; + return requestQueueNameCache.computeIfAbsent(remoteInterface, k -> "{" + name + ":" + k.getName() + "}"); } protected RFuture tryPollAckAgainAsync(RemoteInvocationOptions optionsCopy, diff --git a/redisson/src/main/java/org/redisson/remote/BaseRemoteService.java b/redisson/src/main/java/org/redisson/remote/BaseRemoteService.java index 820ce5bc6..e675512e9 100644 --- a/redisson/src/main/java/org/redisson/remote/BaseRemoteService.java +++ b/redisson/src/main/java/org/redisson/remote/BaseRemoteService.java @@ -92,12 +92,7 @@ public abstract class BaseRemoteService { public String getRequestQueueName(Class remoteInterface) { - String str = requestQueueNameCache.get(remoteInterface); - if (str == null) { - str = "{" + name + ":" + remoteInterface.getName() + "}"; - requestQueueNameCache.put(remoteInterface, str); - } - return str; + return requestQueueNameCache.computeIfAbsent(remoteInterface, k -> "{" + name + ":" + k.getName() + "}"); } protected ByteBuf encode(Object obj) {