From 90201424b60b9f2d2a6a458de451d8c413fee4de Mon Sep 17 00:00:00 2001 From: Nikita Koksharov Date: Thu, 6 Jun 2024 07:52:28 +0300 Subject: [PATCH] Fixed - Redis node random selection doesn't work properly --- .../java/org/redisson/cluster/ClusterConnectionManager.java | 4 ---- .../src/main/java/org/redisson/connection/DNSMonitor.java | 4 ---- 2 files changed, 8 deletions(-) diff --git a/redisson/src/main/java/org/redisson/cluster/ClusterConnectionManager.java b/redisson/src/main/java/org/redisson/cluster/ClusterConnectionManager.java index e5c0b3c45..a621cfc57 100644 --- a/redisson/src/main/java/org/redisson/cluster/ClusterConnectionManager.java +++ b/redisson/src/main/java/org/redisson/cluster/ClusterConnectionManager.java @@ -65,8 +65,6 @@ public class ClusterConnectionManager extends MasterSlaveConnectionManager { private ClusterServersConfig cfg; - private final long seed = ThreadLocalRandom.current().nextLong(); - public ClusterConnectionManager(ClusterServersConfig cfg, Config configCopy) { super(cfg, configCopy); this.serviceManager.setNatMapper(cfg.getNatMapper()); @@ -890,8 +888,6 @@ public class ClusterConnectionManager extends MasterSlaveConnectionManager { int index = 0; if (addresses.size() > 1) { addresses.sort(Comparator.comparing(RedisURI::getHost)); - SplittableRandom r = new SplittableRandom(seed); - index = r.nextInt(addresses.size()); } RedisURI address = addresses.get(index); diff --git a/redisson/src/main/java/org/redisson/connection/DNSMonitor.java b/redisson/src/main/java/org/redisson/connection/DNSMonitor.java index f44738182..e00cbcfe8 100644 --- a/redisson/src/main/java/org/redisson/connection/DNSMonitor.java +++ b/redisson/src/main/java/org/redisson/connection/DNSMonitor.java @@ -56,8 +56,6 @@ public class DNSMonitor { private boolean printed; - private final long seed = ThreadLocalRandom.current().nextLong(); - public DNSMonitor(ConnectionManager connectionManager, RedisClient masterHost, Collection slaveHosts, long dnsMonitoringInterval, AddressResolverGroup resolverGroup) { this.resolver = resolverGroup.getResolver(connectionManager.getServiceManager().getGroup().next()); @@ -129,8 +127,6 @@ public class DNSMonitor { int index = 0; if (addresses.size() > 1) { addresses.sort(Comparator.comparing(RedisURI::getHost)); - SplittableRandom r = new SplittableRandom(seed); - index = r.nextInt(addresses.size()); } RedisURI address = addresses.get(index);