From 2874e751960e6db10bce9a2a6f2644d5f092b6c7 Mon Sep 17 00:00:00 2001 From: Nikita Date: Thu, 11 Aug 2016 13:00:00 +0300 Subject: [PATCH] refactoring --- .../main/java/org/redisson/RedissonBoundedBlockingQueue.java | 5 +++-- .../src/main/java/org/redisson/RedissonRemoteService.java | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/redisson/src/main/java/org/redisson/RedissonBoundedBlockingQueue.java b/redisson/src/main/java/org/redisson/RedissonBoundedBlockingQueue.java index 210386f01..3159f832a 100644 --- a/redisson/src/main/java/org/redisson/RedissonBoundedBlockingQueue.java +++ b/redisson/src/main/java/org/redisson/RedissonBoundedBlockingQueue.java @@ -137,6 +137,7 @@ public class RedissonBoundedBlockingQueue extends RedissonQueue implements final Promise result = new PromiseDelegator(commandExecutor.getConnectionManager().newPromise()) { @Override public boolean cancel(boolean mayInterruptIfRunning) { + super.cancel(mayInterruptIfRunning); return takeFuture.cancel(mayInterruptIfRunning); }; }; @@ -145,14 +146,14 @@ public class RedissonBoundedBlockingQueue extends RedissonQueue implements @Override public void operationComplete(Future future) throws Exception { if (!future.isSuccess()) { - result.setFailure(future.cause()); + result.tryFailure(future.cause()); return; } createSemaphore(null).releaseAsync().addListener(new FutureListener() { @Override public void operationComplete(Future future) throws Exception { - result.setSuccess(takeFuture.getNow()); + result.trySuccess(takeFuture.getNow()); } }); } diff --git a/redisson/src/main/java/org/redisson/RedissonRemoteService.java b/redisson/src/main/java/org/redisson/RedissonRemoteService.java index db0b4809e..c719c1a22 100644 --- a/redisson/src/main/java/org/redisson/RedissonRemoteService.java +++ b/redisson/src/main/java/org/redisson/RedissonRemoteService.java @@ -273,7 +273,7 @@ public class RedissonRemoteService implements RRemoteService { private void invokeMethod(final Class remoteInterface, final RBlockingQueue requestQueue, final RemoteServiceRequest request, RemoteServiceMethod method, String responseName, final ExecutorService executor, - Future cancelRequestFuture, AtomicReference responseHolder) { + Future cancelRequestFuture, final AtomicReference responseHolder) { try { Object result = method.getMethod().invoke(method.getBean(), request.getArgs()); @@ -454,7 +454,7 @@ public class RedissonRemoteService implements RRemoteService { } if (optionsCopy.isAckExpected()) { - RBlockingQueue responseQueue = redisson.getBlockingQueue(responseName, getCodec()); + final RBlockingQueue responseQueue = redisson.getBlockingQueue(responseName, getCodec()); Future ackFuture = responseQueue.pollAsync(optionsCopy.getAckTimeoutInMillis(), TimeUnit.MILLISECONDS); ackFuture.addListener(new FutureListener() { @Override