From 048271f69e067b87dc9ba2d5953f04e73d228350 Mon Sep 17 00:00:00 2001 From: Nikita Date: Mon, 14 Aug 2017 11:57:29 +0300 Subject: [PATCH 1/3] "Can't aquire connection" error should be more informative --- .../main/java/org/redisson/connection/pool/ConnectionPool.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/redisson/src/main/java/org/redisson/connection/pool/ConnectionPool.java b/redisson/src/main/java/org/redisson/connection/pool/ConnectionPool.java index ce8aa3ee9..69f88a1a4 100644 --- a/redisson/src/main/java/org/redisson/connection/pool/ConnectionPool.java +++ b/redisson/src/main/java/org/redisson/connection/pool/ConnectionPool.java @@ -204,7 +204,7 @@ abstract class ConnectionPool { } RedisConnectionException exception = new RedisConnectionException( - "Can't aquire connection to " + entry.getClient().getAddr()); + "Can't aquire connection to " + entry); return connectionManager.newFailedFuture(exception); } From 2082f6203670c8f317f79cf7ac97ece6a39b42a3 Mon Sep 17 00:00:00 2001 From: Nikita Date: Mon, 14 Aug 2017 16:36:47 +0300 Subject: [PATCH 2/3] CompositeCodec added --- .../org/redisson/codec/CompositeCodec.java | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 redisson/src/main/java/org/redisson/codec/CompositeCodec.java diff --git a/redisson/src/main/java/org/redisson/codec/CompositeCodec.java b/redisson/src/main/java/org/redisson/codec/CompositeCodec.java new file mode 100644 index 000000000..51750c5b5 --- /dev/null +++ b/redisson/src/main/java/org/redisson/codec/CompositeCodec.java @@ -0,0 +1,74 @@ +/** + * Copyright 2016 Nikita Koksharov + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.redisson.codec; + +import org.redisson.client.codec.Codec; +import org.redisson.client.protocol.Decoder; +import org.redisson.client.protocol.Encoder; + +/** + * + * @author Nikita Koksharov + * + */ +public class CompositeCodec implements Codec { + + private final Codec mapKeyCodec; + private final Codec mapValueCodec; + private final Codec valueCodec; + + public CompositeCodec(Codec mapKeyCodec, Codec mapValueCodec) { + this(mapKeyCodec, mapValueCodec, null); + } + + public CompositeCodec(Codec mapKeyCodec, Codec mapValueCodec, Codec valueCodec) { + super(); + this.mapKeyCodec = mapKeyCodec; + this.mapValueCodec = mapValueCodec; + this.valueCodec = valueCodec; + } + + @Override + public Decoder getMapValueDecoder() { + return mapValueCodec.getMapKeyDecoder(); + } + + @Override + public Encoder getMapValueEncoder() { + return mapValueCodec.getMapValueEncoder(); + } + + @Override + public Decoder getMapKeyDecoder() { + return mapKeyCodec.getMapKeyDecoder(); + } + + @Override + public Encoder getMapKeyEncoder() { + return mapKeyCodec.getMapKeyEncoder(); + } + + @Override + public Decoder getValueDecoder() { + return valueCodec.getValueDecoder(); + } + + @Override + public Encoder getValueEncoder() { + return valueCodec.getValueEncoder(); + } + +} From 7eead2b06f3532d8de0daf430b7b6aaef7c96dfd Mon Sep 17 00:00:00 2001 From: Nikita Date: Mon, 14 Aug 2017 16:40:06 +0300 Subject: [PATCH 3/3] Comment added --- .../java/org/redisson/connection/ClientConnectionsEntry.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/redisson/src/main/java/org/redisson/connection/ClientConnectionsEntry.java b/redisson/src/main/java/org/redisson/connection/ClientConnectionsEntry.java index c148c35e8..6ff67abab 100644 --- a/redisson/src/main/java/org/redisson/connection/ClientConnectionsEntry.java +++ b/redisson/src/main/java/org/redisson/connection/ClientConnectionsEntry.java @@ -32,6 +32,11 @@ import org.slf4j.LoggerFactory; import io.netty.util.concurrent.Future; import io.netty.util.concurrent.FutureListener; +/** + * + * @author Nikita Koksharov + * + */ public class ClientConnectionsEntry { final Logger log = LoggerFactory.getLogger(getClass());