From 14b39b20ffd0a9ea21cf8ecea620e6d67b16e16d Mon Sep 17 00:00:00 2001
From: Nikita <abracham.mitchell@gmail.com>
Date: Mon, 25 Jun 2018 19:46:21 +0300
Subject: [PATCH] refactoring

---
 .../redisson/connection/MasterSlaveEntry.java    |  9 ++-------
 .../connection/balancer/LoadBalancerManager.java | 16 ++++++----------
 2 files changed, 8 insertions(+), 17 deletions(-)

diff --git a/redisson/src/main/java/org/redisson/connection/MasterSlaveEntry.java b/redisson/src/main/java/org/redisson/connection/MasterSlaveEntry.java
index 198fbbce5..2dfd10e2e 100644
--- a/redisson/src/main/java/org/redisson/connection/MasterSlaveEntry.java
+++ b/redisson/src/main/java/org/redisson/connection/MasterSlaveEntry.java
@@ -17,7 +17,6 @@ package org.redisson.connection;
 
 import java.net.InetSocketAddress;
 import java.net.URI;
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.LinkedList;
@@ -348,10 +347,6 @@ public class MasterSlaveEntry {
         return addSlave(client, freezed, nodeType);
     }
 
-    public ClientConnectionsEntry getSlaveEntry(RedisClient client) {
-        return slaveBalancer.getEntry(client);
-    }
-    
     public Collection<ClientConnectionsEntry> getAllEntries() {
         return slaveBalancer.getEntries();
     }
@@ -453,8 +448,8 @@ public class MasterSlaveEntry {
                 oldMaster.freezeMaster(FreezeReason.MANAGER);
                 slaveDown(oldMaster);
 
-                slaveBalancer.changeType(oldMaster.getClient(), NodeType.SLAVE);
-                slaveBalancer.changeType(newMasterClient, NodeType.MASTER);
+                slaveBalancer.changeType(oldMaster.getClient().getAddr(), NodeType.SLAVE);
+                slaveBalancer.changeType(newMasterClient.getAddr(), NodeType.MASTER);
 
                 // more than one slave available, so master can be removed from slaves
                 if (!config.checkSkipSlavesInit()
diff --git a/redisson/src/main/java/org/redisson/connection/balancer/LoadBalancerManager.java b/redisson/src/main/java/org/redisson/connection/balancer/LoadBalancerManager.java
index c80a9f231..e8a9fda3d 100644
--- a/redisson/src/main/java/org/redisson/connection/balancer/LoadBalancerManager.java
+++ b/redisson/src/main/java/org/redisson/connection/balancer/LoadBalancerManager.java
@@ -66,12 +66,8 @@ public class LoadBalancerManager {
         pubSubConnectionPool = new PubSubConnectionPool(config, connectionManager, entry);
     }
 
-    public void changeType(RedisClient redisClient, NodeType nodeType) {
-        ClientConnectionsEntry entry = getEntry(redisClient);
-        changeType(nodeType, entry);
-    }
-
-    protected void changeType(NodeType nodeType, ClientConnectionsEntry entry) {
+    public void changeType(InetSocketAddress address, NodeType nodeType) {
+        ClientConnectionsEntry entry = getEntry(address);
         if (entry != null) {
             if (connectionManager.isClusterMode()) {
                 entry.getClient().getConfig().setReadOnly(nodeType == NodeType.SLAVE && connectionManager.getConfig().getReadMode() != ReadMode.MASTER);
@@ -79,7 +75,7 @@ public class LoadBalancerManager {
             entry.setNodeType(nodeType);
         }
     }
-    
+
     public RFuture<Void> add(final ClientConnectionsEntry entry) {
         RPromise<Void> result = new RedissonPromise<Void>();
         
@@ -200,7 +196,7 @@ public class LoadBalancerManager {
         return getEntry(redisClient) != null;
     }
 
-    protected ClientConnectionsEntry getEntry(URI addr) {
+    private ClientConnectionsEntry getEntry(URI addr) {
         for (ClientConnectionsEntry entry : client2Entry.values()) {
             InetSocketAddress entryAddr = entry.getClient().getAddr();
             if (URIBuilder.compare(entryAddr, addr)) {
@@ -210,7 +206,7 @@ public class LoadBalancerManager {
         return null;
     }
     
-    protected ClientConnectionsEntry getEntry(InetSocketAddress address) {
+    private ClientConnectionsEntry getEntry(InetSocketAddress address) {
         for (ClientConnectionsEntry entry : client2Entry.values()) {
             InetSocketAddress addr = entry.getClient().getAddr();
             if (addr.getAddress().equals(address.getAddress()) && addr.getPort() == address.getPort()) {
@@ -220,7 +216,7 @@ public class LoadBalancerManager {
         return null;
     }
 
-    public ClientConnectionsEntry getEntry(RedisClient redisClient) {
+    private ClientConnectionsEntry getEntry(RedisClient redisClient) {
         return client2Entry.get(redisClient);
     }