Commit Graph

99 Commits (ff51196856d9955bede6327eba0c23c400700dc4)
 

Author SHA1 Message Date
Alexandru Dima ff51196856
Update dev dependencies 4 years ago
Alexandru Dima f860d7aea6
update to latest css language service 4 years ago
Alexandru Dima 5bce191a0c
Adopt latest `monaco-editor-core` 4 years ago
Alexandru Dima ae46dfbebd
Merge pull request #10 from jpett/patch-1
Fix error Cannot read property 'getModeId' of null
4 years ago
jpett a78b94491d
Fix error Cannot read property 'getModeId' of null
When a monaco editor instance is created and destroyed shortly afterwards, the error 'Cannot read property 'getModeId' of null' occurs. As far as I could trace this issue, this happens because in onModelAdd a call to setTimeout is made with a delay of 500ms, which in turn calls _doValidate. If the monaco editor instance is destroyed before the callback is called, _doValidate tries to call model.getModeId(), but model is null. The little additional null-check in this PR ensures no exception is thrown if the model cannot be determined.

Unfortunately, I wasn't able to reproduce this problem using vs code playground or similar. It is easily reproducible in our angular application which uses monaco-editor@0.21.2. Here, we display a monaco editor instance in a property editor on the right side of the screen which is newly instantiated whenever the user selects a new object on the left side of the screen. If you quickly change the items selected the error occurs. I'll be happy to provide a screen recording including the Chrome dev tools console if needed.

Last but not least: Thanks for all your great work! :)
4 years ago
Alex Dima 23bd524cc3
3.1.1 4 years ago
Alex Dima 6bf10f7b32
Fixes microsoft/monaco-editor#2158 4 years ago
Alex Dima 7a8e83e2a0
3.1.0 5 years ago
Alex Dima 966506278e
Set `printWidth` to 100 5 years ago
Alex Dima 8cc4272694
update deps 5 years ago
Alex Dima 2bb6a93576
Improve dts script 5 years ago
Alex Dima c4c0a98ef7
improve `.npmignore` 5 years ago
Alex Dima e77dc655b9
3.0.0 5 years ago
Alex Dima a972e015fb
update to latest CSS language service 5 years ago
Alex Dima 5ebacc725f
Run prettier 5 years ago
Alex Dima 9b90326796
Add prettier 5 years ago
Alex Dima 5db3946e4a
Use the global `monaco` only in the AMD case (see microsoft/monaco-editor#1974) 5 years ago
Alex Dima ff1c7a5a5c
Stop using `Thenable` 5 years ago
Alex Dima cbf1d6a12b
2.7.0 5 years ago
Alex Dima 1bab4e14fe
Adopt latest monaco-editor-core 5 years ago
Alex Dima 5b08a3733e
2.6.0 5 years ago
Alex Dima f98e0fdff0
Adopt latest monaco-editor-core 5 years ago
Martin Aeschlimann de56cb86c2 add mode configuration 5 years ago
Martin Aeschlimann 972bdb614d switch to terser 5 years ago
Martin Aeschlimann 1f303216a8 update dependencies 5 years ago
Martin Aeschlimann 16f88ea8e7 add selection range provider 5 years ago
Martin Aeschlimann b445fa011e update css-lsservice 5 years ago
Alex Dima aeab384123 2.5.1 6 years ago
Alex Dima 3fec0c1bcf Adopt latest monaco-editor-core 6 years ago
Martin Aeschlimann 19554e0f06 2.5.0 6 years ago
Martin Aeschlimann d818518649 update service 6 years ago
Martin Aeschlimann f94dca207a 2.4.0 6 years ago
Martin Aeschlimann 4db1f4f9f2 update & adopt 6 years ago
Alex Dima 8a2b406930 Adopt native promises 6 years ago
Alex Dima a450f6054c 2.3.0 6 years ago
Alex Dima f6d638686b Adopt latest editor & new npm deps 6 years ago
Martin Aeschlimann 1d4b425215
Merge pull request #7 from ricsam/master
Fix indentation on the CSS test page
6 years ago
Richard Samuelsson 4f984dbade Fix indentation in the CSS test page 6 years ago
Alex Dima 5ab4ffac72 Add support for testing via a local web server 7 years ago
Alex Dima ce1fb4aab7 2.2.0 7 years ago
Alex Dima 61c5a476e7 Update deps 7 years ago
Alex Dima 4336d9c40f Adopt monaco-editor-core@0.14.0 7 years ago
Martin Aeschlimann ac6eafddf5 fix FoldingRange conversion (1-based) 7 years ago
Martin Aeschlimann 54f904f6fe use thenable 7 years ago
Martin Aeschlimann e6f882e3f1 add folding provider & update dependencies 7 years ago
Martin Aeschlimann a021ab7a38 2.1.1 7 years ago
Martin Aeschlimann c0250bfca3 remove markers on settings change. Fixes Microsoft/monaco-editor#840 7 years ago
Martin Aeschlimann 1fc63ab25c add color decorators. Fixes Microsoft/monaco-editor#132 7 years ago
Alexandru Dima c77aec86d5
Merge pull request #6 from rcjsuen/disposable
Remove unused IDisposable array
7 years ago
Remy Suen 47d02d469a Remove unused IDisposable array
The IDisposables created by the registration of language providers
were originally stored in an array. However, that array is not
actually used anywhere in the code so it should be removed instead.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
7 years ago