monaco-editor

Commit Graph

Author	SHA1	Message	Date
Alexandru Dima	0d7f7069ca	update deps	4 years ago
jpett	a78b94491d	Fix error Cannot read property 'getModeId' of null When a monaco editor instance is created and destroyed shortly afterwards, the error 'Cannot read property 'getModeId' of null' occurs. As far as I could trace this issue, this happens because in onModelAdd a call to setTimeout is made with a delay of 500ms, which in turn calls _doValidate. If the monaco editor instance is destroyed before the callback is called, _doValidate tries to call model.getModeId(), but model is null. The little additional null-check in this PR ensures no exception is thrown if the model cannot be determined. Unfortunately, I wasn't able to reproduce this problem using vs code playground or similar. It is easily reproducible in our angular application which uses monaco-editor@0.21.2. Here, we display a monaco editor instance in a property editor on the right side of the screen which is newly instantiated whenever the user selects a new object on the left side of the screen. If you quickly change the items selected the error occurs. I'll be happy to provide a screen recording including the Chrome dev tools console if needed. Last but not least: Thanks for all your great work! :)	4 years ago
Alex Dima	966506278e	Set `printWidth` to 100	5 years ago
Alex Dima	a972e015fb	update to latest CSS language service	5 years ago
Alex Dima	5ebacc725f	Run prettier	5 years ago
Alex Dima	5db3946e4a	Use the global `monaco` only in the AMD case (see microsoft/monaco-editor#1974 )	5 years ago
Alex Dima	ff1c7a5a5c	Stop using `Thenable`	5 years ago
Alex Dima	1bab4e14fe	Adopt latest monaco-editor-core	5 years ago
Martin Aeschlimann	16f88ea8e7	add selection range provider	5 years ago
Martin Aeschlimann	b445fa011e	update css-lsservice	5 years ago
Alex Dima	3fec0c1bcf	Adopt latest monaco-editor-core	6 years ago
Martin Aeschlimann	4db1f4f9f2	update & adopt	6 years ago
Alex Dima	8a2b406930	Adopt native promises	6 years ago
Alex Dima	f6d638686b	Adopt latest editor & new npm deps	6 years ago
Alex Dima	4336d9c40f	Adopt monaco-editor-core@0.14.0	7 years ago
Martin Aeschlimann	ac6eafddf5	fix FoldingRange conversion (1-based)	7 years ago
Martin Aeschlimann	e6f882e3f1	add folding provider & update dependencies	7 years ago
Martin Aeschlimann	c0250bfca3	remove markers on settings change. Fixes Microsoft/monaco-editor#840	7 years ago
Martin Aeschlimann	1fc63ab25c	add color decorators. Fixes Microsoft/monaco-editor#132	7 years ago
Alex Dima	8006ce3fe9	Adopt new monaco-editor-core	7 years ago
Remy Suen	b622773393	Fix hovers use of MarkedString to IMarkdownString The conversion code for hovers ignored MarkedString's `language` property which caused the content to be rendered incorrectly. The code has been corrected to honour the property and now creates the code block correctly. Signed-off-by: Remy Suen <remy.suen@gmail.com>	7 years ago
Alex Dima	64d2e8c8ef	Ship ESM; Adopt latest deps	7 years ago
Martin Aeschlimann	076db3dcc7	Adopt WorkspaceEdit.changes API changes	8 years ago
Martin Aeschlimann	9a25293cce	When I switch the editor's language and values, the previous language error markers stick around Microsoft/monaco-editor#475	8 years ago
Martin Aeschlimann	f032b58597	Adopt SnippetString, publish 1.3.1	8 years ago
Martin Aeschlimann	a0f4474c54	Markers appear for wrong language id. Fixes Microsoft/monaco-editor#111	8 years ago
Martin Aeschlimann	01cf2aeea8	Remove markers on model dipsose (Microsoft/monaco-editor#111 )	9 years ago
Alex Dima	7fb0572779	Update to monaco-editor-core@0.5.1	9 years ago
Martin Aeschlimann	ef359fa044	1.0	9 years ago
Martin Aeschlimann	ff503e756e	rename to cssMode, cssWorker & create dev, min	9 years ago
Martin Aeschlimann	293cc3aa55	Release build script	9 years ago
Martin Aeschlimann	2380ce142c	Init	9 years ago

32 Commits (4d93e35acf607a85ca4eaff15fc0a309696ee71d)