Commit Graph

2724 Commits (1134d5e82b14bc18e3cd56548402e56221ef7345)
 

Author SHA1 Message Date
JC Chu dffb2ebf1f Add Modula-3 support 4 years ago
Orta cc8da6b7fb Adds a regex fix for the perf_hooks import in TS 4.1 4 years ago
jpett a78b94491d
Fix error Cannot read property 'getModeId' of null
When a monaco editor instance is created and destroyed shortly afterwards, the error 'Cannot read property 'getModeId' of null' occurs. As far as I could trace this issue, this happens because in onModelAdd a call to setTimeout is made with a delay of 500ms, which in turn calls _doValidate. If the monaco editor instance is destroyed before the callback is called, _doValidate tries to call model.getModeId(), but model is null. The little additional null-check in this PR ensures no exception is thrown if the model cannot be determined.

Unfortunately, I wasn't able to reproduce this problem using vs code playground or similar. It is easily reproducible in our angular application which uses monaco-editor@0.21.2. Here, we display a monaco editor instance in a property editor on the right side of the screen which is newly instantiated whenever the user selects a new object on the left side of the screen. If you quickly change the items selected the error occurs. I'll be happy to provide a screen recording including the Chrome dev tools console if needed.

Last but not least: Thanks for all your great work! :)
4 years ago
Martin Aeschlimann 22746ae61a adopt schemaValidation and schemaRequest (for https://github.com/microsoft/monaco-editor/issues/1852) 4 years ago
David Gonzalez c86c7346a8
Missing breaking change
I'm not sure what release starting 0.21.0 caused it, not other methods being static now beyond parse() and file() in monaco.uri.
Regards and keep doing this amazing project awesomER!
4 years ago
Hugo Fonseca c16c8958e5 terraform Fix heredoc 4 years ago
Alexandru Dima be30e69ac2
Merge pull request #115 from stla/removedWhiteSpaces
removed white spaces in constants
4 years ago
Alexandru Dima fd9146b41b
Merge pull request #114 from stla/roxygenTags
completed the list of roxygen tags
4 years ago
stla e111b302bc removed white spaces in constants 4 years ago
stla 4f3f360837 completed the list of roxygen tags 4 years ago
Alexandru Dima 506dba1e33
Merge pull request #113 from philipsens/master
Add auto indent for xml
4 years ago
Sergi Philipsen a7400fc99f Add auto indent for xml 4 years ago
Alexandru Dima d2028b1a75
Merge pull request #2161 from Gittenburg/master
Fix comment in sample
4 years ago
Alex Dima 9605800975
0.21.2 4 years ago
Alex Dima 728fe88d80
Prepare for 0.21.2 4 years ago
Alex Dima 23bd524cc3
3.1.1 4 years ago
Alex Dima 6bf10f7b32
Fixes microsoft/monaco-editor#2158 4 years ago
Gittenburg b817a5d6b8 Fix comment in sample 4 years ago
Alex Dima 7e0afc8f43
Fixes #2155: Adopt latest typedoc themes 4 years ago
Alex Dima 47ffd256b9
Link to example of editor integrated with `vscode-textmate` and `vscode-oniguruma` 4 years ago
Alex Dima e782cf103f
0.21.1 4 years ago
Alex Dima 2a06ef83d7
Fix version number 4 years ago
Alex Dima 3623161a9c
Prepare for `0.21.1` 4 years ago
Alex Dima bdd3de5f00
3.1.1 4 years ago
Alex Dima 10776a19b8
3.2.1 4 years ago
Alex Dima 425b0e3c9e
2.1.1 4 years ago
Alex Dima 2dcf85a5e8
4.1.1 4 years ago
Alex Dima 68b07de006
update screenshot 4 years ago
Alex Dima 08c64ab616
Fixes #2153: Add a dispose() method to the code lens provider 4 years ago
Alexandru Dima d456465df5
Merge pull request #112 from mbtools/master
Overhaul of ABAP language based on release 7.54
4 years ago
Marc Bernard feeaa714aa Fix operators and testcase 4 years ago
Marc Bernard 575f6764c9 Indentation 4 years ago
Marc Bernard 371afd3515 Overhaul of ABAP language based on release 7.54 4 years ago
Martin Aeschlimann f379dfc153
Merge pull request #12 from pankajk07/master
Fixes microsoft/monaco-editor#2101
4 years ago
Alexandru Dima 6c41187baa
Merge pull request #71 from pgherveou/patch-1
Add missing setWorkerOptions
4 years ago
Alex Dima bbedc82694
commit generated file 4 years ago
PG Herveou 8664abc331
Add missing setWorkerOptions 4 years ago
Alex Dima 8b9e18c804
Avoid scrollbars in the runner iframe 4 years ago
Pankaj Khandelwal 0b66311655
Fixes microsoft/monaco-editor#2101 4 years ago
pankajk07 f53b683f37
Merge pull request #1 from microsoft/master
Sync
4 years ago
Alex Dima c5586a25cf
Update `printWidth` to 100 4 years ago
Alexandru Dima 398fd0eee6
Update CHANGELOG.md 4 years ago
Alex Dima 365af6fa65
Add shadow dom sample 4 years ago
Alex Dima 3c52c0fadf
update deps 4 years ago
Alex Dima 6950069f37
Remove X-UA-Compatible meta 4 years ago
Alex Dima 4b25f66566
Reuse common `node_modules` (reduce maintenance) 4 years ago
Alex Dima db4c9f21b4
Add missing samples 5 years ago
Alex Dima 271fd7dcab
2.0.0 5 years ago
Alex Dima 1a0f0274a0
adopt latest `monaco-editor` 5 years ago
Martin Aeschlimann cbb9baab8c Support schema relative imports. Fixes microsoft/monaco-editor#2097 5 years ago