From dfbd13e4486ad5ca6ddb71375c21ee5cdbac7966 Mon Sep 17 00:00:00 2001 From: Alex Dima Date: Tue, 6 Sep 2016 17:01:56 +0200 Subject: [PATCH] Fixes Microsoft/monaco-editor#168: remove enablement, context menu for action --- ...dding-an-action-to-an-editor-instance.html | 34 ------------------- .../sample.js | 34 ------------------- 2 files changed, 68 deletions(-) diff --git a/test/playground.generated/interacting-with-the-editor-adding-an-action-to-an-editor-instance.html b/test/playground.generated/interacting-with-the-editor-adding-an-action-to-an-editor-instance.html index a25e14e2..f1d60351 100644 --- a/test/playground.generated/interacting-with-the-editor-adding-an-action-to-an-editor-instance.html +++ b/test/playground.generated/interacting-with-the-editor-adding-an-action-to-an-editor-instance.html @@ -69,45 +69,11 @@ editor.addAction({ keybindingContext: null, - // Control if the action should show up in the context menu and where. - // Built-in groups: - // 1_goto/* => e.g. 1_goto/1_peekDefinition - // 2_change/* => e.g. 2_change/2_format - // 3_edit/* => e.g. 3_edit/1_copy - // 4_tools/* => e.g. 4_tools/1_commands - // You can also create your own group. - // Defaults to null (don't show in context menu). - contextMenuGroupId: '2_change/2_bla', - // Method that will be executed when the action is triggered. // @param editor The editor instance is passed in as a convinience run: function(ed) { alert("i'm running => " + ed.getPosition()); return null; - }, - - // Optional enablement conditions. All members are optional - enablement: { - // The action is enabled only if text in the editor is focused (e.g. blinking cursor). - // Warning: This condition will be disabled if the action is marked to be displayed in the context menu - // Defaults to false. - textFocus: true, - - // The action is enabled only if the editor or its widgets have focus (e.g. focus is in find widget). - // Defaults to false. - //widgetFocus: true, - - // The action is enabled only if the editor is not in read only mode. - // Defaults to false. - //writeableEditor: true, - - // The action is enabled only if the cursor position is over a word (i.e. not whitespace). - // Defaults to false. - wordAtPosition: true, - - // The action is enabled only if the cursor position is over tokens of a certain kind. - // Defaults to no tokens required. - tokensAtPosition: ['identifier', '', 'keyword'], } }); diff --git a/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js b/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js index 258b7266..fd85fac6 100644 --- a/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js +++ b/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js @@ -31,44 +31,10 @@ editor.addAction({ keybindingContext: null, - // Control if the action should show up in the context menu and where. - // Built-in groups: - // 1_goto/* => e.g. 1_goto/1_peekDefinition - // 2_change/* => e.g. 2_change/2_format - // 3_edit/* => e.g. 3_edit/1_copy - // 4_tools/* => e.g. 4_tools/1_commands - // You can also create your own group. - // Defaults to null (don't show in context menu). - contextMenuGroupId: '2_change/2_bla', - // Method that will be executed when the action is triggered. // @param editor The editor instance is passed in as a convinience run: function(ed) { alert("i'm running => " + ed.getPosition()); return null; - }, - - // Optional enablement conditions. All members are optional - enablement: { - // The action is enabled only if text in the editor is focused (e.g. blinking cursor). - // Warning: This condition will be disabled if the action is marked to be displayed in the context menu - // Defaults to false. - textFocus: true, - - // The action is enabled only if the editor or its widgets have focus (e.g. focus is in find widget). - // Defaults to false. - //widgetFocus: true, - - // The action is enabled only if the editor is not in read only mode. - // Defaults to false. - //writeableEditor: true, - - // The action is enabled only if the cursor position is over a word (i.e. not whitespace). - // Defaults to false. - wordAtPosition: true, - - // The action is enabled only if the cursor position is over tokens of a certain kind. - // Defaults to no tokens required. - tokensAtPosition: ['identifier', '', 'keyword'], } });