From 47d02d469a9dd81a5434b8eb7ecaf9ea2e805f66 Mon Sep 17 00:00:00 2001 From: Remy Suen Date: Fri, 13 Apr 2018 18:39:01 -0400 Subject: [PATCH] Remove unused IDisposable array The IDisposables created by the registration of language providers were originally stored in an array. However, that array is not actually used anywhere in the code so it should be removed instead. Signed-off-by: Remy Suen --- src/cssMode.ts | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/cssMode.ts b/src/cssMode.ts index 8dd4882a..140ffb18 100644 --- a/src/cssMode.ts +++ b/src/cssMode.ts @@ -11,14 +11,10 @@ import * as languageFeatures from './languageFeatures'; import Promise = monaco.Promise; import Uri = monaco.Uri; -import IDisposable = monaco.IDisposable; export function setupMode(defaults: LanguageServiceDefaultsImpl): void { - let disposables: IDisposable[] = []; - const client = new WorkerManager(defaults); - disposables.push(client); const worker = (first: Uri, ...more: Uri[]): Promise => { return client.getLanguageServiceWorker(...[first].concat(more)); @@ -26,14 +22,14 @@ export function setupMode(defaults: LanguageServiceDefaultsImpl): void { let languageId = defaults.languageId; - disposables.push(monaco.languages.registerCompletionItemProvider(languageId, new languageFeatures.CompletionAdapter(worker))); - disposables.push(monaco.languages.registerHoverProvider(languageId, new languageFeatures.HoverAdapter(worker))); - disposables.push(monaco.languages.registerDocumentHighlightProvider(languageId, new languageFeatures.DocumentHighlightAdapter(worker))); - disposables.push(monaco.languages.registerDefinitionProvider(languageId, new languageFeatures.DefinitionAdapter(worker))); - disposables.push(monaco.languages.registerReferenceProvider(languageId, new languageFeatures.ReferenceAdapter(worker))); - disposables.push(monaco.languages.registerDocumentSymbolProvider(languageId, new languageFeatures.DocumentSymbolAdapter(worker))); - disposables.push(monaco.languages.registerRenameProvider(languageId, new languageFeatures.RenameAdapter(worker))); - disposables.push(new languageFeatures.DiagnostcsAdapter(languageId, worker)); + monaco.languages.registerCompletionItemProvider(languageId, new languageFeatures.CompletionAdapter(worker)); + monaco.languages.registerHoverProvider(languageId, new languageFeatures.HoverAdapter(worker)); + monaco.languages.registerDocumentHighlightProvider(languageId, new languageFeatures.DocumentHighlightAdapter(worker)); + monaco.languages.registerDefinitionProvider(languageId, new languageFeatures.DefinitionAdapter(worker)); + monaco.languages.registerReferenceProvider(languageId, new languageFeatures.ReferenceAdapter(worker)); + monaco.languages.registerDocumentSymbolProvider(languageId, new languageFeatures.DocumentSymbolAdapter(worker)); + monaco.languages.registerRenameProvider(languageId, new languageFeatures.RenameAdapter(worker)); + new languageFeatures.DiagnostcsAdapter(languageId, worker)); }