From 5204ce83004428574c0252a95d2902b15ca563d4 Mon Sep 17 00:00:00 2001 From: SpaceComet Date: Mon, 16 Aug 2021 12:39:24 -0400 Subject: [PATCH 1/3] Spelling fixed on the website playground. --- .../configure-javascript-defaults/sample.js | 2 +- .../adding-an-action-to-an-editor-instance/sample.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/website/playground/new-samples/extending-language-services/configure-javascript-defaults/sample.js b/website/playground/new-samples/extending-language-services/configure-javascript-defaults/sample.js index fed8f0d4..aa52b7df 100644 --- a/website/playground/new-samples/extending-language-services/configure-javascript-defaults/sample.js +++ b/website/playground/new-samples/extending-language-services/configure-javascript-defaults/sample.js @@ -1,4 +1,4 @@ -// Add additonal d.ts files to the JavaScript language service and change. +// Add additional d.ts files to the JavaScript language service and change. // Also change the default compilation options. // The sample below shows how a class Facts is declared and introduced // to the system and how the compiler is told to use ES6 (target=2). diff --git a/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js b/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js index c4d5c7f9..8fd6e828 100644 --- a/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js +++ b/website/playground/new-samples/interacting-with-the-editor/adding-an-action-to-an-editor-instance/sample.js @@ -42,7 +42,7 @@ editor.addAction({ contextMenuOrder: 1.5, // Method that will be executed when the action is triggered. - // @param editor The editor instance is passed in as a convinience + // @param editor The editor instance is passed in as a convenience run: function(ed) { alert("i'm running => " + ed.getPosition()); return null; From 5b3c0d011664ae57611c0adc0f66df0250358e50 Mon Sep 17 00:00:00 2001 From: SpaceComet Date: Mon, 16 Aug 2021 12:40:13 -0400 Subject: [PATCH 2/3] Update old information on the website playground --- .../listening-to-key-events/sample.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/website/playground/new-samples/interacting-with-the-editor/listening-to-key-events/sample.js b/website/playground/new-samples/interacting-with-the-editor/listening-to-key-events/sample.js index ea6e80b6..6639aef8 100644 --- a/website/playground/new-samples/interacting-with-the-editor/listening-to-key-events/sample.js +++ b/website/playground/new-samples/interacting-with-the-editor/listening-to-key-events/sample.js @@ -7,4 +7,5 @@ var myBinding = editor.addCommand(monaco.KeyCode.F9, function() { alert('F9 pressed!'); }); -// When cleaning up remember to call myBinding.dispose() +// You can't dispose `addCommand` +// If you need to dispose it you might use `addAction` or `registerCommand` From e42557eac77acb23ba45b3ac50e485a09633af19 Mon Sep 17 00:00:00 2001 From: SpaceComet Date: Thu, 19 Aug 2021 17:35:24 -0400 Subject: [PATCH 3/3] Sample in the playground updated. --- .../customizing-the-appearence/exposed-colors/sample.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/playground/new-samples/customizing-the-appearence/exposed-colors/sample.js b/website/playground/new-samples/customizing-the-appearence/exposed-colors/sample.js index 0da824d6..24d5cc1c 100644 --- a/website/playground/new-samples/customizing-the-appearence/exposed-colors/sample.js +++ b/website/playground/new-samples/customizing-the-appearence/exposed-colors/sample.js @@ -140,7 +140,7 @@ monaco.editor.create(document.getElementById("container"), { 'peekViewEditor.matchHighlightBackground' // Match highlight color in the peek view editor. /* -var colors = require('vs/platform/registry/common/platform').Registry.data['base.contributions.colors'].colorSchema.properties +var colors = require('vs/platform/registry/common/platform').Registry.data.get('base.contributions.colors').colorSchema.properties Object.keys(colors).forEach(function(key) { var val = colors[key]; console.log( '//' + val.description + '\n' + key);