From 05f3891fd1cabacb09506951c79e428126152f3e Mon Sep 17 00:00:00 2001 From: Orta Therox Date: Sat, 29 Feb 2020 18:17:05 -0500 Subject: [PATCH] Bump the TypeScript version, and fix the changes to the monaco API --- .github/workflows/ci.yml | 1 + package-lock.json | 6 +++--- package.json | 2 +- src/languageFeatures.ts | 4 ++-- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d5aa4737..2a58f98d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,3 +12,4 @@ jobs: node-version: '10.x' - run: npm install - run: npm run compile + - run: npm run prepublishOnly diff --git a/package-lock.json b/package-lock.json index 618b8820..080cf8fb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -79,9 +79,9 @@ } }, "typescript": { - "version": "3.7.5", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.7.5.tgz", - "integrity": "sha512-/P5lkRXkWHNAbcJIiHPfRoKqyd7bsyCma1hZNUGfn20qm64T6ZBlrzprymeu918H+mB/0rIg2gGK/BXkhhYgBw==", + "version": "3.8.3", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.8.3.tgz", + "integrity": "sha512-MYlEfn5VrLNsgudQTVJeNaQFUAI7DkhnOjdpAp4T+ku1TfQClewlbSuTVHiA+8skNBgaf02TL/kLOvig4y3G8w==", "dev": true } } diff --git a/package.json b/package.json index 9dc43270..73e7dcfb 100644 --- a/package.json +++ b/package.json @@ -25,6 +25,6 @@ "monaco-plugin-helpers": "^1.0.2", "requirejs": "^2.3.6", "terser": "^4.6.3", - "typescript": "^3.7.5" + "typescript": "^3.8.2" } } diff --git a/src/languageFeatures.ts b/src/languageFeatures.ts index b114e3c8..574d2097 100644 --- a/src/languageFeatures.ts +++ b/src/languageFeatures.ts @@ -691,7 +691,7 @@ export class FormatOnTypeAdapter extends FormatHelper implements monaco.language export class CodeActionAdaptor extends FormatHelper implements monaco.languages.CodeActionProvider { - public async provideCodeActions(model: monaco.editor.ITextModel, range: Range, context: monaco.languages.CodeActionContext, token: CancellationToken): Promise { + public async provideCodeActions(model: monaco.editor.ITextModel, range: Range, context: monaco.languages.CodeActionContext, token: CancellationToken): Promise { const resource = model.uri; const start = model.getOffsetAt({ lineNumber: range.startLineNumber, column: range.startColumn }); const end = model.getOffsetAt({ lineNumber: range.endLineNumber, column: range.endColumn }); @@ -701,7 +701,7 @@ export class CodeActionAdaptor extends FormatHelper implements monaco.languages. const codeFixes = await worker.getCodeFixesAtPosition(resource.toString(), start, end, errorCodes, formatOptions); if (!codeFixes || model.isDisposed()) { - return; + return { actions: [], dispose:() => {} }; } const actions = codeFixes.filter(fix => {