Summary: Fix minor typos in messages and comments
Test Plan: No major changes to prevent compilation and usage
Reviewers: mvourlakos
Reviewed By: mvourlakos
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17894
--moving a task now is not synced immediately to
other docks. Syncing takes place only in the end.
The dock in which the user changed the launchers
order sends a signal to other docks to update
theirs launchers order.
BUG: 401232
--in plasma 5.13 there are cases the libtaskmanager
shows two launchers because we delay the launcher
removal for the bouncing animation. A way
to fix this by the user is to disable all startups
through plasma systemsettings->launch feedback
for the taskmanager. But because this is a
default plasma option many users would feel
uncomfortable when the launching animation
breaks. Such apps were gimp and inkscape.
This patch handles that case in order to provide
a nice no-breaking launcher animation for
these apps also.
-- when removing a task and there are surrounding
separators then the hidden spacers are updated
immediately for the neighbour tasks. In such case
in order to not break the removal animation a small
margin must applied.
--when only launchers are shown and the user
has chosen to disable any active indicator
then the plasmoid should behave only as
a smart launchers list with no window
capabilities
--in some cases after activity changes some tasks
are shown empty because some ghost tasks are created.
This was tracked down to hidden TaskDelegates spacers.
--libtaskmanager sometimes adds items and
hasnt set its full settings. After the addition
it updates some of the settings. This fix
is trying to fix that circumstances by not having
any blocking warnings
--following issue from #730 more qml code
was found that wasnt releasing connect signals
properly. That could create crashes because
already deleted qml objects could receive such
signals. That was observed after qt>=5.9.2
--trying to show all tasks in all states directly
when the environment is in !compositing
--block all animations (removals/showings) when
the environment is in !compositing
--add more animation phases in order to provide
a better experience for the inAttention bouncing
animation
--add visual debuggers for the spacers and padders
needed for the bouncing animation
--move the release of signals manual bindings for
tasks delegates from onRemove event of the delegate
at Component.onDestruction. The crash was happening
when the code path(onRemove event) wasnt occuring,
so the bindings werent released.
--during assigning activities for a launcher
a window that had a launcher for the active
activity maybe doesnt have any more when it is removed.
in this cases the removal animation should be
played
--when two or more consequently launchers were bouncing
their animation was broken because they were changing
places. This patch catches these cases and provides
a proper way to show these animations.
--this is only for the case that the launcher is called
through a shortcut. The dock mask in that case uses the
midThickness and for that the bouncing launcher must be reduced
--identify startups better in order to distinguish
them to those that belong to launcher and should be
shown immediately and those that dont belong in any
launcher and they shouldnt be shown
--when the attention animation is played for a task
and the user hovers that task, the animation is ended
smoothly and if the mouse is still hovering the task,
the tasks are restored correctly
Michail Vourlakos
Yuri Chornoivan