From a1da0bae1bfc3b98193a03f37f3aae8407787e9e Mon Sep 17 00:00:00 2001
From: Michail Vourlakos <mvourlakos@gmail.com>
Date: Tue, 27 Jul 2021 14:10:28 +0300
Subject: [PATCH] disable inattention blocked slide-in when no needed

--when the task is no more inattention then dock should
slide-out when the visibility mode requests it even
when the inattention timer has not finished yet

BUG:439497
---
 plasmoid/package/contents/ui/main.qml | 51 ++++++++++++++++-----------
 1 file changed, 31 insertions(+), 20 deletions(-)

diff --git a/plasmoid/package/contents/ui/main.qml b/plasmoid/package/contents/ui/main.qml
index 370b224db..b7e7d812d 100644
--- a/plasmoid/package/contents/ui/main.qml
+++ b/plasmoid/package/contents/ui/main.qml
@@ -64,6 +64,8 @@ Item {
     property bool vertical: plasmoid.formFactor === PlasmaCore.Types.Vertical ? true : false
     property bool isHorizontal: plasmoid.formFactor === PlasmaCore.Types.Horizontal ? true : false
 
+    property bool hasTaskDemandingAttention: false
+
     property int clearWidth
     property int clearHeight
 
@@ -253,11 +255,24 @@ Item {
         target: plasmoid
         property: "status"
         value: {
-            if (tasksModel.anyTaskDemandsAttentionInValidTime || root.dragSource) {
-                return PlasmaCore.Types.NeedsAttentionStatus;
+            var hastaskinattention = root.hasTaskDemandingAttention && tasksModel.anyTaskDemandsAttentionInValidTime;
+            return (hastaskinattention || root.dragSource) ? PlasmaCore.Types.NeedsAttentionStatus : PlasmaCore.Types.PassiveStatus;
+        }
+    }
+
+    Binding {
+        target: root
+        property: "hasTaskDemandingAttention"
+        when: appletAbilities.indexer.isReady
+        value: {
+            for (var i=0; i<appletAbilities.indexer.layout.children.length; ++i){
+                var item = appletAbilities.indexer.layout.children[i];
+                if (item && item.isDemandingAttention) {
+                    return true;
+                }
             }
 
-            return PlasmaCore.Types.PassiveStatus;
+            return false;
         }
     }
 
@@ -506,9 +521,12 @@ Item {
         }
 
         onAnyTaskDemandsAttentionChanged: {
+            anyTaskDemandsAttentionInValidTime = anyTaskDemandsAttention;
+
             if (anyTaskDemandsAttention){
-                anyTaskDemandsAttentionInValidTime = true;
-                attentionTimerComponent.createObject(root);
+                attentionTimer.start();
+            } else {
+                attentionTimer.stop();
             }
         }
 
@@ -723,21 +741,14 @@ Item {
         thinTooltip.local.showIsBlocked: root.contextMenu || root.windowPreviewIsShown
     }
 
-    Component{
-        id: attentionTimerComponent
-        Timer{
-            id: attentionTimer
-            interval:8500
-            onTriggered: {
-                tasksModel.anyTaskDemandsAttentionInValidTime = false;
-                destroy();
-
-                if (appletAbilities.debug.timersEnabled) {
-                    console.log("plasmoid timer: attentionTimer called...");
-                }
-            }
-            Component.onCompleted: {
-                start();
+    Timer{
+        id: attentionTimer
+        interval:8500
+        onTriggered: {
+            tasksModel.anyTaskDemandsAttentionInValidTime = false;
+
+            if (appletAbilities.debug.timersEnabled) {
+                console.log("plasmoid timer: attentionTimer called...");
             }
         }
     }