From 480570bab2ed00cc77afb4d840a02d15623b5d18 Mon Sep 17 00:00:00 2001 From: Michail Vourlakos Date: Tue, 20 Jun 2017 17:28:55 +0300 Subject: [PATCH] fix #555,correct -1px struts calculations --- app/dockview.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/dockview.cpp b/app/dockview.cpp index 21e4f4b7e..4293e9030 100644 --- a/app/dockview.cpp +++ b/app/dockview.cpp @@ -608,8 +608,15 @@ void DockView::setLocalGeometry(const QRect &geometry) void DockView::updateAbsDockGeometry(bool bypassChecks) { + //! there was a -1 in height and width here. The reason of this + //! if I remember correctly was related to multi-screen but I cant + //! remember exactly the reason, something related to rigth edge in + //! multi screen environment. BUT this was breaking the entire AlwaysVisible + //! experience with struts. Removing them in order to restore correct + //! behavior and keeping this comment in order to check for + //! multi-screen breakage QRect absGeometry {x() + m_localGeometry.x(), y() + m_localGeometry.y() - , m_localGeometry.width() - 1, m_localGeometry.height() - 1}; + , m_localGeometry.width(), m_localGeometry.height()}; if (m_absGeometry == absGeometry && !bypassChecks) return;