From 3877b6736dc84639d0993950bbf9a70221c130a1 Mon Sep 17 00:00:00 2001
From: Michail Vourlakos <mvourlakos@gmail.com>
Date: Wed, 10 Jan 2018 16:43:00 +0200
Subject: [PATCH] fix binding loop when opening settings window

--fix missing id
---
 .../package/contents/configuration/LatteCheckBoxStyle.qml  | 2 ++
 .../contents/configuration/LatteDockConfiguration.qml      | 7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/shell/package/contents/configuration/LatteCheckBoxStyle.qml b/shell/package/contents/configuration/LatteCheckBoxStyle.qml
index edcd94677..21b61293c 100644
--- a/shell/package/contents/configuration/LatteCheckBoxStyle.qml
+++ b/shell/package/contents/configuration/LatteCheckBoxStyle.qml
@@ -28,6 +28,8 @@ import org.kde.plasma.core 2.0 as PlasmaCore
 import org.kde.plasma.components 2.0 as PlasmaComponents
 
 PlasmaStyles.CheckBoxStyle{
+    id: checkboxStyle
+
     label: PlasmaComponents.Label {
         id: labelStyleTxt
         text: control.text
diff --git a/shell/package/contents/configuration/LatteDockConfiguration.qml b/shell/package/contents/configuration/LatteDockConfiguration.qml
index cf23d3318..194ca7616 100644
--- a/shell/package/contents/configuration/LatteDockConfiguration.qml
+++ b/shell/package/contents/configuration/LatteDockConfiguration.qml
@@ -102,16 +102,17 @@ FocusScope {
         id: content
 
         Layout.minimumWidth: width
-        Layout.minimumHeight: height
+        Layout.minimumHeight: calculatedHeight
         Layout.preferredWidth: width
-        Layout.preferredHeight: height
-        height: header.height + headerSpacer.height+ tabBar.height + pagesBackground.height + actionButtons.height + spacing * 3
+        Layout.preferredHeight: calculatedHeight
         width: dialog.maxWidth
 
         anchors.horizontalCenter: parent.horizontalCenter
         anchors.top: parent.top
         spacing: units.smallSpacing
 
+        property int calculatedHeight: header.height + headerSpacer.height+ tabBar.height + pagesBackground.height + actionButtons.height + spacing * 3
+
         Keys.onPressed: {
             if (event.key === Qt.Key_Escape) {
                 dockConfig.hideConfigWindow();