From 3230f9d370099703c5d7c4c3530feb69bb8f22d3 Mon Sep 17 00:00:00 2001 From: Lana Black Date: Mon, 18 Mar 2024 09:57:35 +0000 Subject: [PATCH] ColorGroup comment. --- declarativeimports/core/iconitem.cpp | 10 +++++++--- declarativeimports/core/iconitem.h | 6 +++++- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/declarativeimports/core/iconitem.cpp b/declarativeimports/core/iconitem.cpp index 0bbd143de..9be011980 100644 --- a/declarativeimports/core/iconitem.cpp +++ b/declarativeimports/core/iconitem.cpp @@ -40,8 +40,10 @@ IconItem::IconItem(QQuickItem *parent) m_textureChanged(false), m_sizeChanged(false), m_usesPlasmaTheme(false), - m_lastValidSourceName(QString()), - m_colorGroup(Plasma::Theme::NormalColorGroup) + m_lastValidSourceName(QString()) + // FIXME: + // See the comment in the header + // m_colorGroup(Plasma::Theme::NormalColorGroup) { setFlag(ItemHasContents, true); connect(KIconLoader::global(), SIGNAL(iconLoaderSettingsChanged()), @@ -96,7 +98,9 @@ void IconItem::setSource(const QVariant &source) } else { if (!m_svgIcon) { m_svgIcon = std::make_unique(this); - m_svgIcon->setColorGroup(m_colorGroup); + // FIXME: + // See the comment in the header + //m_svgIcon->setColorGroup(m_colorGroup); m_svgIcon->setStatus(KSvg::Svg::Normal); m_svgIcon->setUsingRenderingCache(false); m_svgIcon->setDevicePixelRatio((window() ? window()->devicePixelRatio() : qApp->devicePixelRatio())); diff --git a/declarativeimports/core/iconitem.h b/declarativeimports/core/iconitem.h index 9d6a4da89..6c4ee6790 100644 --- a/declarativeimports/core/iconitem.h +++ b/declarativeimports/core/iconitem.h @@ -23,6 +23,7 @@ // KF #include +#include // this file is based on PlasmaCore::IconItem class, thanks to KDE namespace Latte { @@ -49,7 +50,10 @@ class IconItem : public QQuickItem * Specifies the color group to use for this icon * This only applies to icons loaded from the plasma theme */ - Q_PROPERTY(Plasma::Theme::ColorGroup colorGroup READ colorGroup WRITE setColorGroup NOTIFY colorGroupChanged) + // FIXME: + // this needs to be replaced with ColorSet from Kirigami2 + // https://api.kde.org/frameworks/kirigami/html/classKirigami_1_1Platform_1_1PlatformTheme.html + //Q_PROPERTY(Plasma::Theme::ColorGroup colorGroup READ colorGroup WRITE setColorGroup NOTIFY colorGroupChanged) /** * Specifies the overlay(s) for this icon