From 2e3139239e22eb24b11be9de3a33b5054b590870 Mon Sep 17 00:00:00 2001 From: Michail Vourlakos Date: Sat, 21 Oct 2017 10:21:40 +0300 Subject: [PATCH] fix clang warnings --improve readability of the build process when using clang by fixing small things to not show some warnings --- app/dockconfigview.cpp | 2 +- app/dockcorona.cpp | 8 ++++++++ app/dockview.cpp | 4 ++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/app/dockconfigview.cpp b/app/dockconfigview.cpp index 5b52abbba..11daa7ed4 100644 --- a/app/dockconfigview.cpp +++ b/app/dockconfigview.cpp @@ -388,7 +388,7 @@ void DockConfigView::updateLaunchersForGroup(int groupInt) //! as a start point if (dockCorona && dockCorona->layoutManager() && dockCorona->layoutManager()->currentLayout()) { if ((group == Dock::LayoutLaunchers && dockCorona->layoutManager()->currentLayout()->launchers().isEmpty()) - || group == Dock::GlobalLaunchers && dockCorona->universalSettings()->launchers().isEmpty()) { + || (group == Dock::GlobalLaunchers && dockCorona->universalSettings()->launchers().isEmpty())) { Plasma::Containment *c = m_dockView->containment(); diff --git a/app/dockcorona.cpp b/app/dockcorona.cpp index d4dba4bef..d29c96aea 100644 --- a/app/dockcorona.cpp +++ b/app/dockcorona.cpp @@ -425,6 +425,10 @@ QRegion DockCorona::availableScreenRegion(int id) const } break; + + default: + //! bypass clang warnings + break; } } } @@ -477,6 +481,10 @@ QRect DockCorona::availableScreenRect(int id) const case Plasma::Types::BottomEdge: available.setBottomLeft({available.x(), dockRect.top()}); break; + + default: + //! bypass clang warnings + break; } } } diff --git a/app/dockview.cpp b/app/dockview.cpp index 51ba28fa7..75d5c3815 100644 --- a/app/dockview.cpp +++ b/app/dockview.cpp @@ -568,6 +568,10 @@ QRect DockView::maximumNormalGeometry() maxGeometry.setRect(xPos, yPos, maxWidth, maxHeight); break; + + default: + //! bypass clang warnings + break; } //! this is needed in order to preserve that the top dock will be above