Merge pull request #254 from jaesung9507/doack_panic

[fix] rtmp: validate buffer length in ServerSession.doAck
pull/256/head
yoko 2 years ago committed by GitHub
commit 3bd0836117
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -234,7 +234,11 @@ func (s *ServerSession) doMsg(stream *Stream) error {
}
func (s *ServerSession) doAck(stream *Stream) error {
seqNum := bele.BeUint32(stream.msg.buff.Bytes())
buf := stream.msg.buff.Bytes()
if len(buf) < 4 {
return base.ErrRtmpShortBuffer
}
seqNum := bele.BeUint32(buf)
Log.Infof("[%s] < R Acknowledgement. ignore. sequence number=%d.", s.UniqueKey(), seqNum)
return nil
}

Loading…
Cancel
Save