mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
375fd15fbf
Refactor `modules/indexer` to make it more maintainable. And it can be
easier to support more features. I'm trying to solve some of issue
searching, this is a precursor to making functional changes.
Current supported engines and the index versions:
| engines | issues | code |
| - | - | - |
| db | Just a wrapper for database queries, doesn't need version | - |
| bleve | The version of index is **2** | The version of index is **6**
|
| elasticsearch | The old index has no version, will be treated as
version **0** in this PR | The version of index is **1** |
| meilisearch | The old index has no version, will be treated as version
**0** in this PR | - |
## Changes
### Split
Splited it into mutiple packages
```text
indexer
├── internal
│ ├── bleve
│ ├── db
│ ├── elasticsearch
│ └── meilisearch
├── code
│ ├── bleve
│ ├── elasticsearch
│ └── internal
└── issues
├── bleve
├── db
├── elasticsearch
├── internal
└── meilisearch
```
- `indexer/interanal`: Internal shared package for indexer.
- `indexer/interanal/[engine]`: Internal shared package for each engine
(bleve/db/elasticsearch/meilisearch).
- `indexer/code`: Implementations for code indexer.
- `indexer/code/internal`: Internal shared package for code indexer.
- `indexer/code/[engine]`: Implementation via each engine for code
indexer.
- `indexer/issues`: Implementations for issues indexer.
### Deduplication
- Combine `Init/Ping/Close` for code indexer and issues indexer.
- ~Combine `issues.indexerHolder` and `code.wrappedIndexer` to
`internal.IndexHolder`.~ Remove it, use dummy indexer instead when the
indexer is not ready.
- Duplicate two copies of creating ES clients.
- Duplicate two copies of `indexerID()`.
### Enhancement
- [x] Support index version for elasticsearch issues indexer, the old
index without version will be treated as version 0.
- [x] Fix spell of `elastic_search/ElasticSearch`, it should be
`Elasticsearch`.
- [x] Improve versioning of ES index. We don't need `Aliases`:
- Gitea does't need aliases for "Zero Downtime" because it never delete
old indexes.
- The old code of issues indexer uses the orignal name to create issue
index, so it's tricky to convert it to an alias.
- [x] Support index version for meilisearch issues indexer, the old
index without version will be treated as version 0.
- [x] Do "ping" only when `Ping` has been called, don't ping
periodically and cache the status.
- [x] Support the context parameter whenever possible.
- [x] Fix outdated example config.
- [x] Give up the requeue logic of issues indexer: When indexing fails,
call Ping to check if it was caused by the engine being unavailable, and
only requeue the task if the engine is unavailable.
- It is fragile and tricky, could cause data losing (It did happen when
I was doing some tests for this PR). And it works for ES only.
- Just always requeue the failed task, if it caused by bad data, it's a
bug of Gitea which should be fixed.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
|
2 years ago | |
|---|---|---|
| .. | ||
| actions | 2 years ago | |
| activitypub | 2 years ago | |
| analyze | 2 years ago | |
| assetfs | 2 years ago | |
| auth | 2 years ago | |
| avatar | 2 years ago | |
| base | 2 years ago | |
| cache | 2 years ago | |
| charset | 2 years ago | |
| container | 2 years ago | |
| context | 2 years ago | |
| csv | 2 years ago | |
| doctor | 2 years ago | |
| emoji | 2 years ago | |
| eventsource | 2 years ago | |
| generate | 2 years ago | |
| git | 2 years ago | |
| gitgraph | 2 years ago | |
| graceful | 2 years ago | |
| hcaptcha | 2 years ago | |
| highlight | 2 years ago | |
| hostmatcher | 2 years ago | |
| html | 2 years ago | |
| httpcache | 2 years ago | |
| httplib | 2 years ago | |
| indexer | 2 years ago | |
| issue/template | 2 years ago | |
| json | 2 years ago | |
| label | 2 years ago | |
| lfs | 2 years ago | |
| log | 2 years ago | |
| markup | 2 years ago | |
| mcaptcha | 2 years ago | |
| metrics | 2 years ago | |
| migration | 2 years ago | |
| mirror | 2 years ago | |
| nosql | 2 years ago | |
| notification | 2 years ago | |
| options | 2 years ago | |
| packages | 2 years ago | |
| paginator | 2 years ago | |
| pprof | 2 years ago | |
| private | 2 years ago | |
| process | 2 years ago | |
| proxy | 2 years ago | |
| proxyprotocol | 2 years ago | |
| public | 2 years ago | |
| queue | 2 years ago | |
| recaptcha | 2 years ago | |
| references | 2 years ago | |
| regexplru | 2 years ago | |
| repository | 2 years ago | |
| secret | 2 years ago | |
| session | 2 years ago | |
| setting | 2 years ago | |
| sitemap | 2 years ago | |
| ssh | 2 years ago | |
| storage | 2 years ago | |
| structs | 2 years ago | |
| svg | 2 years ago | |
| sync | 2 years ago | |
| system | 2 years ago | |
| templates | 2 years ago | |
| test | 2 years ago | |
| testlogger | 2 years ago | |
| timeutil | 2 years ago | |
| translation | 2 years ago | |
| turnstile | 2 years ago | |
| typesniffer | 2 years ago | |
| updatechecker | 2 years ago | |
| upload | 2 years ago | |
| uri | 2 years ago | |
| user | 2 years ago | |
| util | 2 years ago | |
| validation | 2 years ago | |
| web | 2 years ago | |
| webhook | 2 years ago | |