mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
affdd40296
Replace #19922 , which is stale since my last review: https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506 and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546 Close #19769 Changes: 1. Use `<button>` instead of `<div>` for buttons 2. Prevent default event handler in `initGlobalButtonClickOnEnter` 3. Fix the incorrect call to `pullrequest_targetbranch_change` 4. Add a slight margin-left to the input element to make UI look better The logic in repo-issue.js is not ideal, but this PR isn't going to touch the logic. This is also an example for future developers to understand how to make buttons work properly. ### Before ![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png) ### After * Add a slight margin-left. * The `Cancel` button is focused. ![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png) Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
2 years ago | |
---|---|---|
.. | ||
admin | 2 years ago | |
comp | 2 years ago | |
aria.js | 2 years ago | |
aria.md | 3 years ago | |
captcha.js | 2 years ago | |
citation.js | 2 years ago | |
clipboard.js | 2 years ago | |
codeeditor.js | 2 years ago | |
colorpicker.js | 2 years ago | |
common-global.js | 2 years ago | |
common-issue.js | 3 years ago | |
common-organization.js | 3 years ago | |
contextpopup.js | 2 years ago | |
copycontent.js | 2 years ago | |
dropzone.js | 2 years ago | |
emoji.js | 2 years ago | |
eventsource.sharedworker.js | 3 years ago | |
file-fold.js | 2 years ago | |
formatting.js | 2 years ago | |
heatmap.js | 2 years ago | |
imagediff.js | 2 years ago | |
install.js | 3 years ago | |
notification.js | 2 years ago | |
org-team.js | 3 years ago | |
pull-view-file.js | 3 years ago | |
repo-branch.js | 3 years ago | |
repo-code.js | 2 years ago | |
repo-code.test.js | 2 years ago | |
repo-commit.js | 2 years ago | |
repo-common.js | 3 years ago | |
repo-diff-filetree.js | 2 years ago | |
repo-diff.js | 2 years ago | |
repo-editor.js | 3 years ago | |
repo-findfile.js | 2 years ago | |
repo-findfile.test.js | 2 years ago | |
repo-graph.js | 2 years ago | |
repo-home.js | 3 years ago | |
repo-issue-content.js | 2 years ago | |
repo-issue-pr-form.js | 2 years ago | |
repo-issue.js | 2 years ago | |
repo-legacy.js | 2 years ago | |
repo-migrate.js | 2 years ago | |
repo-migration.js | 2 years ago | |
repo-projects.js | 2 years ago | |
repo-release.js | 2 years ago | |
repo-settings.js | 3 years ago | |
repo-template.js | 3 years ago | |
repo-unicode-escape.js | 3 years ago | |
repo-wiki.js | 3 years ago | |
serviceworker.js | 2 years ago | |
sshkey-helper.js | 3 years ago | |
stopwatch.js | 2 years ago | |
tablesort.js | 2 years ago | |
tribute.js | 2 years ago | |
user-auth-webauthn.js | 2 years ago | |
user-auth.js | 3 years ago | |
user-settings.js | 3 years ago |