You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/modules
flozzone a39287cd4e
Send mail to issue/pr assignee/reviewer also when OnMention is set (#18707)
I want to address #17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.

From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see #17892 as a bug. Could we therefore mark this ticket as such?

The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?

@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?

#12774 (comment)

Fix #17892
3 years ago
..
activitypub format with gofumpt (#18184) 3 years ago
analyze Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 4 years ago
appstate format with gofumpt (#18184) 3 years ago
auth format with gofumpt (#18184) 3 years ago
avatar format with gofumpt (#18184) 3 years ago
base format with gofumpt (#18184) 3 years ago
cache format with gofumpt (#18184) 3 years ago
charset format with gofumpt (#18184) 3 years ago
context Display template path of current page in dev mode (#18717) 3 years ago
convert API: Return primary language and repository language stats API URL (#18396) 3 years ago
csv format with gofumpt (#18184) 3 years ago
doctor Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 3 years ago
emoji format with gofumpt (#18184) 3 years ago
eventsource Simplify parameter types (#18006) 3 years ago
generate Use base32 for 2FA scratch token (#18384) 3 years ago
git Change git.cmd to RunWithContext (#18693) 3 years ago
gitgraph Change git.cmd to RunWithContext (#18693) 3 years ago
graceful format with gofumpt (#18184) 3 years ago
hcaptcha hCaptcha Support (#12594) 5 years ago
highlight format with gofumpt (#18184) 3 years ago
hostmatcher Simplify parameter types (#18006) 3 years ago
httpcache format with gofumpt (#18184) 3 years ago
httplib refactor httplib (#18338) 3 years ago
indexer Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 3 years ago
json Make gitea, gitea-vet future-proof (#18361) 3 years ago
lfs format with gofumpt (#18184) 3 years ago
log format with gofumpt (#18184) 3 years ago
markup Prevent NPE on partial match of compare URL and allow short SHA1 compare URLs (#18472) 3 years ago
metrics format with gofumpt (#18184) 3 years ago
migration add test coverage for original author conversion during migrations (#18506) 3 years ago
nosql format with gofumpt (#18184) 3 years ago
notification Send mail to issue/pr assignee/reviewer also when OnMention is set (#18707) 3 years ago
options format with gofumpt (#18184) 3 years ago
password Fixed assert statements. (#16089) 4 years ago
pprof refactor: move from io/ioutil to io and os package (#17109) 4 years ago
private Validate migration files (#18203) 3 years ago
process format with gofumpt (#18184) 3 years ago
proxy Return nil proxy function if proxy not enabled (#16742) 4 years ago
public Fix mime-type detection for HTTP server (#18370) 3 years ago
queue Add number in queue status to monitor page (#18712) 3 years ago
recaptcha refactor: move from io/ioutil to io and os package (#17109) 4 years ago
references format with gofumpt (#18184) 3 years ago
repository Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 3 years ago
secret Use `CryptoRandomBytes` instead of `CryptoRandomString` (#18439) 3 years ago
session format with gofumpt (#18184) 3 years ago
setting Update SSH Server crypto settings (#18697) 3 years ago
ssh format with gofumpt (#18184) 3 years ago
storage format with gofumpt (#18184) 3 years ago
structs Add apply-patch, basic revert and cherry-pick functionality (#17902) 3 years ago
svg refactor: move from io/ioutil to io and os package (#17109) 4 years ago
sync Fix missing unlock in uniquequeue (#9790) 5 years ago
templates format with gofumpt (#18184) 3 years ago
test format with gofumpt (#18184) 3 years ago
timeutil format with gofumpt (#18184) 3 years ago
translation Refactor i18n, use Locale to provide i18n/translation related functions (#18648) 3 years ago
typesniffer format with gofumpt (#18184) 3 years ago
updatechecker format with gofumpt (#18184) 3 years ago
upload Simplify parameter types (#18006) 3 years ago
uri Prevent NPE if gitea uploader fails to open url (#18080) 3 years ago
user Add gitea-vet (#10948) 5 years ago
util Fix non-ASCII search on database (#18437) 3 years ago
validation format with gofumpt (#18184) 3 years ago
web Fix route wrap (#18360) 3 years ago