You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Hester Gong
476a043a5f
Refactor delete_modal_actions template and use it for project column related actions (#24097)
Co-Author: @wxiaoguang
This PR is to fix
https://github.com/go-gitea/gitea/issues/23318#issuecomment-1506275446 .
The way to fix this in this PR is to use `delete_modal_actions.tmpl`
here both to fix this issue and keep ui consistency (as suggested by
[TODO
here](4299c3b7db/templates/projects/view.tmpl (L161)))
And this PR also refactors `delete_modal_actions.tmpl` and its related
styles, and use the template for more modal actions:
1. Added template attributes:
* locale
* ModalButtonStyle: "yes" (default) or "confirm"
* ModalButtonCancelText
* ModalButtonOkText
2. Rename `delete_modal_actions.tmpl` template to
`modal_actions_confirm.tmpl` because it is not only used for action
modals deletion now.
3. Refactored css related to modals into `web_src/css/modules/modal.css`
and improved the styles.
4. Also use the template for PR deletion modal and remove issue
dependency modal.
5. Some modals should also use the template, but not sure how to open
them, so mark these modal actions by `{{/* TODO: Convert to
base/modal_actions_confirm */}}`
After (Also tested on arc green):
Hovering on the left buttons
<img width="711" alt="Screen Shot 2023-04-23 at 15 17 12"
src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png">
<img width="786" alt="Screen Shot 2023-04-23 at 15 17 21"
src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png">
Test for functionalities:
https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
|
2 years ago |
| .. |
|
add_reaction.tmpl
|
Use data-tooltip-content for tippy tooltip (#23649)
|
2 years ago |
|
attachments.tmpl
|
Improve template helper functions: string/slice (#24266)
|
2 years ago |
|
comments.tmpl
|
Add project type descriptions in issue badge and improve project icons (#23437)
|
2 years ago |
|
comments_delete_time.tmpl
|
Refactor delete_modal_actions template and use it for project column related actions (#24097)
|
2 years ago |
|
context_menu.tmpl
|
Group template helper functions, remove `Printf`, improve template error messages (#23982)
|
2 years ago |
|
pull.tmpl
|
Fix "Updating branch by merge" bug in "update_branch_by_merge.tmpl" (#23790)
|
2 years ago |
|
pull_merge_instruction.tmpl
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
|
reactions.tmpl
|
Merge template functions "dict/Dict/mergeinto" (#23932)
|
2 years ago |
|
reference_issue_dialog.tmpl
|
Group template helper functions, remove `Printf`, improve template error messages (#23982)
|
2 years ago |
|
sidebar.tmpl
|
Refactor delete_modal_actions template and use it for project column related actions (#24097)
|
2 years ago |
|
update_branch_by_merge.tmpl
|
Fix "Updating branch by merge" bug in "update_branch_by_merge.tmpl" (#23790)
|
2 years ago |
