github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/web_src/js
History
wxiaoguang 027014d7de
Fix webauthn regression and improve code () 
Follow:

* 

There are some bugs in :

* https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966
* the webauthn failure message is never shown and causes console error
* The `document.getElementById('register-button')` and
`document.getElementById('login-button')` is wrong
    * there is no such element in code
    * it causes JS error when a browser doesn't provide webauthn
    * the end user can't see the real error message

These bugs are fixed in this PR.

Other changes:

* Use simple HTML/CSS layouts, no need to use too many `gt-` patches
* Make the webauthn page have correct "page-content" layout
* The "data-webauthn-error-msg" elements are only used to provide locale
texts, so move them into a single "gt-hidden", then no need to repeat a
lot of "gt-hidden" in code
* The `{{.CsrfTokenHtml}}`  is a no-op because there is no form
* Many `hideElem('#webauthn-error')` in code is no-op because the
`webauthn-error` already has "gt-hidden" by default
* Make the tests for "URLEncodedBase64" really test with concrete cases.


Screenshots:

* Error message when webauthn fails (before, there is no error message):

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/93cf9559-d93b-4f06-9d98-0f7032d9c65b)

</details>

* Error message when webauthn is unavailable 

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/ffc0fcd9-b93b-4418-979c-c89bb627aaf2)

</details>
..
components Use correct selector for hiding RSS icon link in the branch selector dropdown ()
features Fix webauthn regression and improve code ()
markup Fix math and mermaid rendering bugs ()
modules Refactor diffFileInfo / DiffTreeStore ()
render Add PDF rendering via PDFObject ()
standalone Add new JS linter rules ()
test Improve emoji and mention matching ()
utils Add two eslint plugins ()
webcomponents Refactor locale number ()
bootstrap.js Improve template system and panic recovery ()
index.js Redesign Scoped Access Tokens ()
jquery.js
…
svg.js Add show timestamp/seconds and fullscreen options to action page ()
svg.test.js Improve `<SvgIcon>` to make it output `svg` node and optimize performance ()
utils.js Clean up WebAuthn javascript code and remove JQuery code ()
utils.test.js Fix webauthn regression and improve code ()