mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
027014d7de
Follow: * #22697 There are some bugs in #22697: * https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966 * the webauthn failure message is never shown and causes console error * The `document.getElementById('register-button')` and `document.getElementById('login-button')` is wrong * there is no such element in code * it causes JS error when a browser doesn't provide webauthn * the end user can't see the real error message These bugs are fixed in this PR. Other changes: * Use simple HTML/CSS layouts, no need to use too many `gt-` patches * Make the webauthn page have correct "page-content" layout * The "data-webauthn-error-msg" elements are only used to provide locale texts, so move them into a single "gt-hidden", then no need to repeat a lot of "gt-hidden" in code * The `{{.CsrfTokenHtml}}` is a no-op because there is no form * Many `hideElem('#webauthn-error')` in code is no-op because the `webauthn-error` already has "gt-hidden" by default * Make the tests for "URLEncodedBase64" really test with concrete cases. Screenshots: * Error message when webauthn fails (before, there is no error message): <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/93cf9559-d93b-4f06-9d98-0f7032d9c65b) </details> * Error message when webauthn is unavailable <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/ffc0fcd9-b93b-4418-979c-c89bb627aaf2) </details> |
2 years ago | |
---|---|---|
.. | ||
chroma | 2 years ago | |
codemirror | 2 years ago | |
editor | 2 years ago | |
features | 2 years ago | |
markup | 2 years ago | |
modules | 2 years ago | |
repo | 2 years ago | |
shared | 2 years ago | |
standalone | 2 years ago | |
themes | 2 years ago | |
actions.css | 2 years ago | |
admin.css | 2 years ago | |
base.css | 2 years ago | |
dashboard.css | 2 years ago | |
explore.css | 2 years ago | |
font_i18n.css | 2 years ago | |
form.css | 2 years ago | |
helpers.css | 2 years ago | |
home.css | 2 years ago | |
index.css | 2 years ago | |
install.css | 2 years ago | |
org.css | 2 years ago | |
repo.css | 2 years ago | |
review.css | 2 years ago | |
user.css | 2 years ago |