mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
affdd40296
Replace #19922 , which is stale since my last review: https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506 and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546 Close #19769 Changes: 1. Use `<button>` instead of `<div>` for buttons 2. Prevent default event handler in `initGlobalButtonClickOnEnter` 3. Fix the incorrect call to `pullrequest_targetbranch_change` 4. Add a slight margin-left to the input element to make UI look better The logic in repo-issue.js is not ideal, but this PR isn't going to touch the logic. This is also an example for future developers to understand how to make buttons work properly. ### Before ![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png) ### After * Add a slight margin-left. * The `Cancel` button is focused. ![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png) Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
2 years ago | |
---|---|---|
.. | ||
actions | 2 years ago | |
branch | 2 years ago | |
cite | 2 years ago | |
diff | 2 years ago | |
editor | 2 years ago | |
find | 2 years ago | |
graph | 2 years ago | |
issue | 2 years ago | |
migrate | 2 years ago | |
projects | 2 years ago | |
pulls | 2 years ago | |
release | 2 years ago | |
settings | 2 years ago | |
wiki | 2 years ago | |
activity.tmpl | 2 years ago | |
blame.tmpl | 2 years ago | |
branch_dropdown.tmpl | 2 years ago | |
clone_buttons.tmpl | 3 years ago | |
clone_script.tmpl | 2 years ago | |
commit_page.tmpl | 2 years ago | |
commit_status.tmpl | 3 years ago | |
commit_statuses.tmpl | 2 years ago | |
commits.tmpl | 2 years ago | |
commits_list.tmpl | 2 years ago | |
commits_list_small.tmpl | 2 years ago | |
commits_table.tmpl | 2 years ago | |
create.tmpl | 2 years ago | |
create_helper.tmpl | 2 years ago | |
empty.tmpl | 2 years ago | |
file_info.tmpl | 2 years ago | |
forks.tmpl | 2 years ago | |
graph.tmpl | 2 years ago | |
header.tmpl | 2 years ago | |
home.tmpl | 2 years ago | |
icon.tmpl | 4 years ago | |
packages.tmpl | 2 years ago | |
search.tmpl | 2 years ago | |
shabox_badge.tmpl | 3 years ago | |
sub_menu.tmpl | 2 years ago | |
unicode_escape_prompt.tmpl | 3 years ago | |
upload.tmpl | 3 years ago | |
user_cards.tmpl | 2 years ago | |
view_file.tmpl | 2 years ago | |
view_list.tmpl | 2 years ago | |
watchers.tmpl | 2 years ago |