You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
delvh
81fe5d6185
Convert `<div class="button">` to `<button class="button">` ( #23337 ) ...
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice
Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.
## Future improvements
As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391 ,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
actions
Fix actions frontend bugs (pagination, long name alignment) and small simplify ( #23370 )
2 years ago
branch
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
cite
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
diff
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
editor
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
find
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
graph
Add context cache as a request level cache ( #22294 )
2 years ago
issue
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
migrate
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
projects
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
pulls
Always go full width in PR view ( #22844 )
2 years ago
release
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
settings
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
wiki
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
activity.tmpl
Add context when rendering labels or emojis ( #23281 )
2 years ago
blame.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
branch_dropdown.tmpl
Refactor branch/tag selector dropdown (first step) ( #23394 )
2 years ago
clone_buttons.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
clone_script.tmpl
Make clone URL use current page's host ( #22808 )
2 years ago
commit_page.tmpl
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
commit_status.tmpl
Fix missing commit status in PR which from forked repo ( #23351 )
2 years ago
commit_statuses.tmpl
Fix hidden commit status on multiple checks ( #22889 )
2 years ago
commits.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
commits_list.tmpl
Add context when rendering labels or emojis ( #23281 )
2 years ago
commits_list_small.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
commits_table.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
create.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
create_helper.tmpl
Add templates to customize text when creating and migrating repositories
2 years ago
empty.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago
file_info.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
forks.tmpl
Add context cache as a request level cache ( #22294 )
2 years ago
graph.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
header.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
home.tmpl
Fix and move "Use this template" button ( #23398 )
2 years ago
icon.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
packages.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago
search.tmpl
Remove Fomantic-UI's `.hidden` CSS class for menu elements ( #22895 )
2 years ago
shabox_badge.tmpl
Fix shabox regression ( #22924 )
2 years ago
sub_menu.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
unicode_escape_prompt.tmpl
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
upload.tmpl
Refactor `i18n` to `locale` ( #20153 )
3 years ago
user_cards.tmpl
Add context cache as a request level cache ( #22294 )
2 years ago
view_file.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
view_list.tmpl
Add wrapper to author to avoid long name ui problem ( #23030 )
2 years ago
watchers.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago
81fe5d6185