github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/public/img
History
delvh 81fe5d6185
Convert `<div class="button">` to `<button class="button">` () 
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
..
auth Add microsoft oauth2 providers ()
emoji Add forge emojies ()
svg Convert `<div class="button">` to `<button class="button">` ()
404.png Optimize png images via Google zopflipng [ci skip] ()
500.png Optimize png images via Google zopflipng [ci skip] ()
apple-touch-icon.png Clean up SVG ()
avatar_default.png Clean up SVG ()
checkmark.png ui for repo/create page
dingtalk.ico Add dingtalk webhook ()
discord.png Implementation of discord webhook ()
failed.png Store task errors following migrations and display them ()
favicon.png Clean up SVG ()
favicon.svg Modernize JS build scripts ()
feishu.png Add feishu webhook support ()
gitea.svg Consolidate Logos and update README header ()
gogs.ico Add Gitea Webhook ()
loading.png optimize public/img/loading.png ()
logo.png Consolidate Logos and update README header ()
logo.svg Update JS dependencies ()
msteams.png fix apple-touch-icon, regenerate images ()
openid-16x16.png optimize all images in public/img ()
packagist.png Add packagist webhook ()
repo_default.png fix apple-touch-icon, regenerate images ()
slack.png optimize all images in public/img ()
telegram.png fix apple-touch-icon, regenerate images ()
wechatwork.png Add support for corporate WeChat webhooks ()