github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/models/db
History
Eng Zer Jun 8b0aaa5f86
test: use `T.TempDir` to create temporary test directory () 
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
..
install Improve install code to avoid low-level mistakes. ()
paginator Use a struct as test options ()
common.go Modify milestone search keywords to be case insensitive again ()
consistency.go Move issues related files into models/issues ()
context.go Fix various typos ()
convert.go Refactor auth package ()
engine.go Allow manager logging to set SQL ()
engine_test.go test: use `T.TempDir` to create temporary test directory ()
error.go Delete related PullAutoMerge and ReviewState on User/Repo Deletion ()
index.go Add more linters to improve code readability ()
iterate.go Add migrate repo archiver and packages storage support on command line ()
list_options.go Add more linters to improve code readability ()
log.go Allow manager logging to set SQL ()
main_test.go Move tests as seperate sub packages to reduce duplicated file names ()
name.go Move user related model into models/user ()
search.go Move user related model into models/user ()
sequence.go Move db related basic functions to models/db ()
sql_postgres_with_schema.go Add more linters to improve code readability ()