mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Follow: * #22697 There are some bugs in #22697: * https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966 * the webauthn failure message is never shown and causes console error * The `document.getElementById('register-button')` and `document.getElementById('login-button')` is wrong * there is no such element in code * it causes JS error when a browser doesn't provide webauthn * the end user can't see the real error message These bugs are fixed in this PR. Other changes: * Use simple HTML/CSS layouts, no need to use too many `gt-` patches * Make the webauthn page have correct "page-content" layout * The "data-webauthn-error-msg" elements are only used to provide locale texts, so move them into a single "gt-hidden", then no need to repeat a lot of "gt-hidden" in code * The `{{.CsrfTokenHtml}}` is a no-op because there is no form * Many `hideElem('#webauthn-error')` in code is no-op because the `webauthn-error` already has "gt-hidden" by default * Make the tests for "URLEncodedBase64" really test with concrete cases. Screenshots: * Error message when webauthn fails (before, there is no error message): <details>  </details> * Error message when webauthn is unavailable <details>  </details> |
2 years ago | |
---|---|---|
.. | ||
admin | 2 years ago | |
comp | 2 years ago | |
captcha.js | 2 years ago | |
citation.js | 2 years ago | |
clipboard.js | 2 years ago | |
codeeditor.js | 2 years ago | |
colorpicker.js | 2 years ago | |
common-global.js | 2 years ago | |
common-issue-list.js | 2 years ago | |
common-issue-list.test.js | 2 years ago | |
common-organization.js | 2 years ago | |
contextpopup.js | 2 years ago | |
copycontent.js | 2 years ago | |
dropzone.js | 2 years ago | |
emoji.js | 2 years ago | |
eventsource.sharedworker.js | 3 years ago | |
file-fold.js | 2 years ago | |
heatmap.js | 2 years ago | |
imagediff.js | 2 years ago | |
install.js | 2 years ago | |
notification.js | 2 years ago | |
org-team.js | 2 years ago | |
pull-view-file.js | 2 years ago | |
repo-branch.js | 2 years ago | |
repo-code.js | 2 years ago | |
repo-code.test.js | 2 years ago | |
repo-commit.js | 2 years ago | |
repo-common.js | 2 years ago | |
repo-diff-filetree.js | 2 years ago | |
repo-diff.js | 2 years ago | |
repo-editor.js | 2 years ago | |
repo-findfile.js | 2 years ago | |
repo-findfile.test.js | 2 years ago | |
repo-graph.js | 2 years ago | |
repo-home.js | 2 years ago | |
repo-issue-content.js | 2 years ago | |
repo-issue-list.js | 2 years ago | |
repo-issue-pr-form.js | 2 years ago | |
repo-issue.js | 2 years ago | |
repo-legacy.js | 2 years ago | |
repo-migrate.js | 2 years ago | |
repo-migration.js | 2 years ago | |
repo-projects.js | 2 years ago | |
repo-release.js | 2 years ago | |
repo-settings.js | 2 years ago | |
repo-template.js | 2 years ago | |
repo-unicode-escape.js | 2 years ago | |
repo-wiki.js | 2 years ago | |
sshkey-helper.js | 3 years ago | |
stopwatch.js | 2 years ago | |
tablesort.js | 2 years ago | |
tribute.js | 2 years ago | |
user-auth-webauthn.js | 2 years ago | |
user-auth.js | 2 years ago | |
user-settings.js | 2 years ago |