You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jason Song a35714372d Fix halfCommitter and WithTx (#22366) ... Related to #22362. I overlooked that there's always `committer.Close()`, like: ```go ctx, committer, err := db.TxContext(db.DefaultContext) if err != nil { return nil } defer committer.Close() // ... if err != nil { return nil } // ... return committer.Commit() ``` So the `Close` of `halfCommitter` should ignore `commit and close`, it's not a rollback. See: [Why `halfCommitter` and `WithTx` should rollback IMMEDIATELY or commit LATER](https://github.com/go-gitea/gitea/pull/22366#issuecomment-1374778612). Co-authored-by: techknowlogick <techknowlogick@gitea.io>		2 years ago
..
activities	Always reuse transaction (#22362)	2 years ago
admin	Implement FSFE REUSE for golang files (#21840)	2 years ago
asymkey	Use ErrInvalidArgument in packages (#22268)	2 years ago
auth	Use random bytes to generate access token (#21959)	2 years ago
avatars	Fix get system setting bug when enabled redis cache (#22295)	2 years ago
db	Fix halfCommitter and WithTx (#22366)	2 years ago
fixtures	Check primary keys for all tables and drop ForeignReference (#21721)	2 years ago
git	Use context parameter in models/git (#22367)	2 years ago
issues	Use context parameter in models/git (#22367)	2 years ago
migrations	Restructure `webhook` module (#22256)	2 years ago
organization	Secrets storage with SecretKey encrypted (#22142)	2 years ago
packages	Use ErrInvalidArgument in packages (#22268)	2 years ago
perm	Rename almost all Ctx functions (#22071)	2 years ago
project	Always reuse transaction (#22362)	2 years ago
pull	refactor some functions to support ctx as first parameter (#21878)	2 years ago
repo	Always reuse transaction (#22362)	2 years ago
secret	Secrets storage with SecretKey encrypted (#22142)	2 years ago
system	Fix set system setting failure once it cached (#22333)	2 years ago
unit	Implement FSFE REUSE for golang files (#21840)	2 years ago
unittest	Use ErrInvalidArgument in packages (#22268)	2 years ago
user	Fix get system setting bug when enabled redis cache (#22295)	2 years ago
webhook	Remove old HookEventType (#22358)	2 years ago
error.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
fixture_generation.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
fixture_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
main_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
migrate.go	Check primary keys for all tables and drop ForeignReference (#21721)	2 years ago
migrate_test.go	Check primary keys for all tables and drop ForeignReference (#21721)	2 years ago
org.go	refactor some functions to support ctx as first parameter (#21878)	2 years ago
org_team.go	Use ErrInvalidArgument in packages (#22268)	2 years ago
org_team_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
org_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
repo.go	Secrets storage with SecretKey encrypted (#22142)	2 years ago
repo_collaboration.go	refactor some functions to support ctx as first parameter (#21878)	2 years ago
repo_collaboration_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
repo_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
repo_transfer.go	Always reuse transaction (#22362)	2 years ago
repo_transfer_test.go	Rename almost all Ctx functions (#22071)	2 years ago
user.go	Implement FSFE REUSE for golang files (#21840)	2 years ago