You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services
Nanguan Lin 49b98e45bc
Fix migration panic due to an empty review comment diff (#28334)
Fix #28328 
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)

ec1feedbf5/modules/git/diff.go (L97-L101)
1 year ago
..
actions Use db.Find instead of writing methods for every object (#28084) 1 year ago
agit Penultimate round of `db.DefaultContext` refactor (#27414) 1 year ago
asymkey Use db.Find instead of writing methods for every object (#28084) 1 year ago
attachment Even more `db.DefaultContext` refactor (#27352) 1 year ago
auth Use db.Find instead of writing methods for every object (#28084) 1 year ago
automerge Improve queue and logger context (#24924) 2 years ago
context Another round of `db.DefaultContext` refactor (#27103) 1 year ago
convert Fix package webhook (#27839) 1 year ago
cron Improve retrying index issues (#27554) 1 year ago
externalaccount Final round of `db.DefaultContext` refactor (#27587) 1 year ago
feed More `db.DefaultContext` refactor (#27265) 1 year ago
forms Fix required error for token name (#28267) 1 year ago
gitdiff Even more `db.DefaultContext` refactor (#27352) 1 year ago
indexer Fix missing issue search index update when changing status (#28325) 1 year ago
issue Penultimate round of `db.DefaultContext` refactor (#27414) 1 year ago
lfs Bump github.com/golang-jwt/jwt to v5 (#25975) 2 years ago
mailer Fix missing mail reply address (#27997) 1 year ago
markup make writing main test easier (#27270) 1 year ago
migrations Fix migration panic due to an empty review comment diff (#28334) 1 year ago
mirror Even more `db.DefaultContext` refactor (#27352) 1 year ago
notify Update status and code index after changing the default branch (#27018) 1 year ago
org Delete repos of org when purge delete user (#27273) 1 year ago
packages Fix RPM/Debian signature key creation (#28352) 1 year ago
pull Use db.Find instead of writing methods for every object (#28084) 1 year ago
release Fix comment permissions (#28213) 1 year ago
repository Make pushUpdate error verbose (#28263) 1 year ago
secrets Use db.Find instead of writing methods for every object (#28084) 1 year ago
task Fix incorrect ctx usage in defer function (#27740) 1 year ago
uinotification Penultimate round of `db.DefaultContext` refactor (#27414) 1 year ago
user Use db.Find instead of writing methods for every object (#28084) 1 year ago
webhook Use db.Find instead of writing methods for every object (#28084) 1 year ago
wiki Even more `db.DefaultContext` refactor (#27352) 1 year ago