You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/web
oliverpool cb7ba8969d
fix: release page for empty or non-existing target (#24659)
Backport #24470

Fixes #24145

---

To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release. This is
particularly useful if the target branch was deleted in the meantime (or
is empty).

I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.

This optimization is covered by the added unit test.

_contributed in the context of @forgejo_
2 years ago
..
admin Fix 500 error if there is a name conflict when edit authentication source (#23832) (#23852) 2 years ago
auth Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (#24035) (#24333) 2 years ago
events Implement FSFE REUSE for golang files (#21840) 2 years ago
explore Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict (#23766) (#23791) 2 years ago
feed User/Org Feed render description as per web (#23887) (#23906) 2 years ago
healthcheck Refactor `setting.Database.UseXXX` to methods (#23354) (#23356) 2 years ago
misc Implement FSFE REUSE for golang files (#21840) 2 years ago
org Fix close org projects (#24588) (#24591) 2 years ago
repo fix: release page for empty or non-existing target (#24659) 2 years ago
shared Only delete secrets belonging to its owner (#24284) (#24286) 2 years ago
user Only delete secrets belonging to its owner (#24284) (#24286) 2 years ago
auth.go Implement FSFE REUSE for golang files (#21840) 2 years ago
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2 years ago
base.go Set `X-Gitea-Debug` header once (#23361) (#23381) 2 years ago
goget.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
home.go Implement FSFE REUSE for golang files (#21840) 2 years ago
metrics.go Implement FSFE REUSE for golang files (#21840) 2 years ago
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2 years ago
swagger_json.go Implement FSFE REUSE for golang files (#21840) 2 years ago
web.go getting the tag list does not require being signed in (#24413) (#24416) 2 years ago
webfinger.go Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) (#23905) 2 years ago