You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services
Giteabot 8b590de186
Fix migration panic due to an empty review comment diff (#28334) (#28362)
Backport #28334 by @lng2020

Fix #28328 
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)

ec1feedbf5/modules/git/diff.go (L97-L101)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
1 year ago
..
actions Always delete existing scheduled action tasks (#27662) (#27688) 1 year ago
agit Move notification interface to services layer (#26915) 1 year ago
asymkey Another round of `db.DefaultContext` refactor (#27103) (#27262) 1 year ago
attachment move repository deletion to service layer (#26948) 1 year ago
auth Unify two factor check (#27915) (#27929) 1 year ago
automerge Improve queue and logger context (#24924) 2 years ago
context Another round of `db.DefaultContext` refactor (#27103) (#27262) 1 year ago
convert Fix package webhook (#27839) (#27855) 1 year ago
cron Improve retrying index issues (#27554) (#27634) 1 year ago
externalaccount More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
feed More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
forms Fix required error for token name (#28267) (#28284) 1 year ago
gitdiff Fix successful return value for `SyncAndGetUserSpecificDiff` (#27152) 1 year ago
indexer Fix missing issue search index update when changing status (#28325) (#28330) 1 year ago
issue Avoid run change title process when the title is same (#27467) (#27558) 1 year ago
lfs Bump github.com/golang-jwt/jwt to v5 (#25975) 2 years ago
mailer Clean up template locale usage (#27856) (#27857) 1 year ago
markup Move web/api context related testing function into a separate package (#26859) 2 years ago
migrations Fix migration panic due to an empty review comment diff (#28334) (#28362) 1 year ago
mirror More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
notify Update status and code index after changing the default branch (#27018) 1 year ago
org Delete repos of org when purge delete user (#27273) (#27728) 1 year ago
packages Fix RPM/Debian signature key creation (#28352) (#28353) 1 year ago
pull Fix poster is not loaded in get default merge message (#27657) (#27666) 1 year ago
release Fix comment permissions (#28213) (#28216) 1 year ago
repository Delete repos of org when purge delete user (#27273) (#27728) 1 year ago
secrets Refactor secrets modification logic (#26873) 1 year ago
task Fix incorrect ctx usage in defer function (#27740) (#27741) 1 year ago
uinotification More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
user Remove action runners on user deletion (#27902) (#27908) 1 year ago
webhook Fix comment permissions (#28213) (#28216) 1 year ago
wiki Fix incorrect test code for error handling (#27139) 1 year ago