You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/pull
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
1 year ago
..
check.go Simplify how git repositories are opened (#28937) 1 year ago
check_test.go Replace assert.Fail with assert.FailNow (#27578) 1 year ago
comment.go Simplify how git repositories are opened (#28937) 1 year ago
commit_status.go Simplify how git repositories are opened (#28937) 1 year ago
edits.go Implement FSFE REUSE for golang files (#21840) 2 years ago
lfs.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 1 year ago
main_test.go make writing main test easier (#27270) 1 year ago
merge.go Abstract hash function usage (#28138) 1 year ago
merge_merge.go Refactor and tidy-up the merge/update branch code (#22568) 2 years ago
merge_prepare.go Refactor merge/update git command calls (#23366) 2 years ago
merge_rebase.go Simplify how git repositories are opened (#28937) 1 year ago
merge_squash.go Simplify how git repositories are opened (#28937) 1 year ago
merge_test.go Support template for merge message description (#22248) 2 years ago
patch.go Simplify how git repositories are opened (#28937) 1 year ago
patch_unmerged.go Implement FSFE REUSE for golang files (#21840) 2 years ago
pull.go Simplify how git repositories are opened (#28937) 1 year ago
pull_test.go Simplify how git repositories are opened (#28937) 1 year ago
review.go Simplify how git repositories are opened (#28937) 1 year ago
temp_repo.go Adjust object format interface (#28469) 1 year ago
update.go Sync branches into databases (#22743) 2 years ago
update_rebase.go Refactor and tidy-up the merge/update branch code (#22568) 2 years ago