You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/api/v1
Giteabot 4dccac3dbf
Fix api error message if fork exists (#24487) (#24493)
Backport #24487 by @fnetX

On the @Forgejo instance of Codeberg, we discovered that forking a repo
which is already forked now returns a 500 Internal Server Error, which
is unexpected. This is an attempt at fixing this.

The error message in the log:
~~~
2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E]
[6450cb8e-113] ForkRepository: repository is already forked by user
[uname: ...., repo path: .../..., fork path: .../...]
~~~

The service that is used for forking returns a custom error message
which is not checked against.

About the order of options:
The case that the fork already exists should be more common, followed by
the case that a repo with the same name already exists for other
reasons. The case that the global repo limit is hit is probably not the
likeliest.

---------

Co-authored-by: Otto Richter (fnetX) <git@fralix.ovh>
2 years ago
..
activitypub Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) (#23905) 2 years ago
admin Fix typo in API route (#24310) (#24332) 2 years ago
misc Implement FSFE REUSE for golang files (#21840) 2 years ago
notify Move `convert` package to services (#22264) 2 years ago
org Add loading yaml label template files (#22976) (#23232) 2 years ago
packages Add Chef package registry (#22554) 2 years ago
repo Fix api error message if fork exists (#24487) (#24493) 2 years ago
settings Implement FSFE REUSE for golang files (#21840) 2 years ago
swagger Implement FSFE REUSE for golang files (#21840) 2 years ago
user Add scopes to API to create token and display them (#22989) 2 years ago
utils Support system hook API (#14537) 2 years ago
api.go Fix access token issue on some public endpoints (#24194) (#24259) 2 years ago
auth.go Implement FSFE REUSE for golang files (#21840) 2 years ago
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2 years ago