You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/models/repo
oliverpool cb7ba8969d
fix: release page for empty or non-existing target (#24659)
Backport #24470

Fixes #24145

---

To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release. This is
particularly useful if the target branch was deleted in the meantime (or
is empty).

I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.

This optimization is covered by the added unit test.

_contributed in the context of @forgejo_
2 years ago
..
archiver.go Implement FSFE REUSE for golang files (#21840) 2 years ago
attachment.go Preview images for Issue cards in Project Board view (#22112) 2 years ago
attachment_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
avatar.go Add context cache as a request level cache (#22294) 2 years ago
collaboration.go Always reuse transaction (#22362) 2 years ago
collaboration_test.go Rename almost all Ctx functions (#22071) 2 years ago
fork.go Implement FSFE REUSE for golang files (#21840) 2 years ago
fork_test.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
git.go Implement FSFE REUSE for golang files (#21840) 2 years ago
issue.go Rename almost all Ctx functions (#22071) 2 years ago
language_stats.go Round language stats percentage using largest remainder (#22026) 2 years ago
main_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
mirror.go Use ErrInvalidArgument in packages (#22268) 2 years ago
pushmirror.go Use ErrInvalidArgument in packages (#22268) 2 years ago
pushmirror_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
redirect.go Implement FSFE REUSE for golang files (#21840) 2 years ago
redirect_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
release.go fix: release page for empty or non-existing target (#24659) 2 years ago
repo.go Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 2 years ago
repo_indexer.go Implement FSFE REUSE for golang files (#21840) 2 years ago
repo_list.go Refactor `setting.Database.UseXXX` to methods (#23354) (#23356) 2 years ago
repo_list_test.go fix calReleaseNumCommitsBehind (#24148) (#24197) 2 years ago
repo_test.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
repo_unit.go Pull Requests: setting to allow edits by maintainers by default, tweak UI (#22862) 2 years ago
star.go Implement FSFE REUSE for golang files (#21840) 2 years ago
star_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
topic.go Sort repo topic labels by name (#24123) (#24153) 2 years ago
topic_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
update.go Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 2 years ago
upload.go Implement FSFE REUSE for golang files (#21840) 2 years ago
user_repo.go Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 2 years ago
user_repo_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
watch.go Implement FSFE REUSE for golang files (#21840) 2 years ago
watch_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
wiki.go Implement FSFE REUSE for golang files (#21840) 2 years ago
wiki_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago