You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/modules
zeripath 41fcf7b7de
Prevent dangling archiver goroutine (#19516)
Within doArchive there is a service goroutine that performs the
archiving function.  This goroutine reports its error using a `chan
error` called `done`. Prior to this PR this channel had 0 capacity
meaning that the goroutine would block until the `done` channel was
cleared - however there are a couple of ways in which this channel might
not be read.

The simplest solution is to add a single space of capacity to the
goroutine which will mean that the goroutine will always complete and
even if the `done` channel is not read it will be simply garbage
collected away.

(The PR also contains two other places when setting up the indexers
which do not leak but where the blocking of the sending goroutine is
also unnecessary and so we should just add a small amount of capacity
and let the sending goroutine complete as soon as it can.)

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
3 years ago
..
activitypub format with gofumpt (#18184) 3 years ago
analyze Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 3 years ago
appstate Use a struct as test options (#19393) 3 years ago
auth RSS/Atom support for Repos (#19055) 3 years ago
avatar format with gofumpt (#18184) 3 years ago
base Update JS dependencies (#19281) 3 years ago
cache Remove legacy `unknwon/com` package (#19298) 3 years ago
charset Don't treat BOM escape sequence as hidden character. (#18909) 3 years ago
container Move reaction to models/issues/ (#19264) 3 years ago
context Use router param for filepath in GetRawFile (#19499) 3 years ago
convert Set correct PR status on 3way on conflict checking (#19457) 3 years ago
csv format with gofumpt (#18184) 3 years ago
doctor [doctor] authorized-keys: fix displayed check name (#19464) 3 years ago
emoji format with gofumpt (#18184) 3 years ago
eventsource Improve Stopwatch behavior (#18930) 3 years ago
generate Use base32 for 2FA scratch token (#18384) 3 years ago
git Pass gitRepo down to GetRawDiff, since its used for main repo and wiki (#19461) 3 years ago
gitgraph Remove `git.Command.Run` and `git.Command.RunInDir*` (#19280) 3 years ago
graceful Add Goroutine stack inspector to admin/monitor (#19207) 3 years ago
hcaptcha hCaptcha Support (#12594) 4 years ago
highlight format with gofumpt (#18184) 3 years ago
hostmatcher remove not needed (#19128) 3 years ago
httpcache format with gofumpt (#18184) 3 years ago
httplib refactor httplib (#18338) 3 years ago
indexer Prevent dangling archiver goroutine (#19516) 3 years ago
json Refactor legacy `unknwon/com` package, improve golangci lint (#19284) 3 years ago
lfs Update HTTP status codes to modern codes (#18063) 3 years ago
log Add Goroutine stack inspector to admin/monitor (#19207) 3 years ago
markup Remove legacy unmaintained packages, refactor to support change default locale (#19308) 3 years ago
metrics format with gofumpt (#18184) 3 years ago
migration Store the foreign ID of issues during migration (#18446) 3 years ago
nosql Remove legacy `unknwon/com` package (#19298) 3 years ago
notification Use a struct as test options (#19393) 3 years ago
options format with gofumpt (#18184) 3 years ago
packages Add Helm Chart registry (#19406) 3 years ago
paginator Remove legacy unmaintained packages, refactor to support change default locale (#19308) 3 years ago
password Fixed assert statements. (#16089) 4 years ago
pprof refactor: move from io/ioutil to io and os package (#17109) 3 years ago
private Add Goroutine stack inspector to admin/monitor (#19207) 3 years ago
process Add Goroutine stack inspector to admin/monitor (#19207) 3 years ago
proxy Return nil proxy function if proxy not enabled (#16742) 4 years ago
public Fix mime-type detection for HTTP server (#18370) 3 years ago
queue Prevent intermittent NPE in queue tests (#19301) 3 years ago
recaptcha refactor: move from io/ioutil to io and os package (#17109) 3 years ago
references format with gofumpt (#18184) 3 years ago
repository Use a struct as test options (#19393) 3 years ago
secret Use `CryptoRandomBytes` instead of `CryptoRandomString` (#18439) 3 years ago
session format with gofumpt (#18184) 3 years ago
setting Fixed registry host value. (#19363) 3 years ago
ssh Add Goroutine stack inspector to admin/monitor (#19207) 3 years ago
storage Add Package Registry (#16510) 3 years ago
structs When updating mirror repo intervals by API reschedule next update too (#19429) 3 years ago
svg refactor: move from io/ioutil to io and os package (#17109) 3 years ago
sync Use queue instead of memory queue in webhook send service (#19390) 3 years ago
templates Refactor legacy `unknwon/com` package, improve golangci lint (#19284) 3 years ago
test Make git.OpenRepository accept Context (#19260) 3 years ago
timeutil Remove legacy unmaintained packages, refactor to support change default locale (#19308) 3 years ago
translation Remove legacy unmaintained packages, refactor to support change default locale (#19308) 3 years ago
typesniffer format with gofumpt (#18184) 3 years ago
updatechecker format with gofumpt (#18184) 3 years ago
upload Simplify parameter types (#18006) 3 years ago
uri Prevent NPE if gitea uploader fails to open url (#18080) 3 years ago
user Add gitea-vet (#10948) 5 years ago
util Remove legacy `unknwon/com` package (#19298) 3 years ago
validation use IsLoopback (#19477) 3 years ago
web Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (#19337) 3 years ago