mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
acd7053e9d
Fix #31625. If `pull_service.NewPullRequest` return an error which misses each `if` check, `CompareAndPullRequestPost` will return immediately, since it doesn't write the HTTP response, a 200 response with empty body will be sent to clients. ```go if err := pull_service.NewPullRequest(ctx, repo, pullIssue, labelIDs, attachments, pullRequest, assigneeIDs); err != nil { if repo_model.IsErrUserDoesNotHaveAccessToRepo(err) { ctx.Error(http.StatusBadRequest, "UserDoesNotHaveAccessToRepo", err.Error()) } else if git.IsErrPushRejected(err) { // ... ctx.JSONError(flashError) } else if errors.Is(err, user_model.ErrBlockedUser) { // ... ctx.JSONError(flashError) } else if errors.Is(err, issues_model.ErrMustCollaborator) { // ... ctx.JSONError(flashError) } return } ``` Not sure what kind of error can cause it to happen, so this PR just expose it. And we can fix it when users report that creating PRs failed with error responses. It's all my guess since I cannot reproduce the problem, but even if it's not related, the code here needs to be improved. |
6 months ago | |
|---|---|---|
| .. | ||
| admin | 7 months ago | |
| auth | 7 months ago | |
| devtest | 8 months ago | |
| events | 1 year ago | |
| explore | 6 months ago | |
| feed | 7 months ago | |
| healthcheck | 1 year ago | |
| misc | 10 months ago | |
| org | 6 months ago | |
| repo | 6 months ago | |
| shared | 8 months ago | |
| user | 6 months ago | |
| base.go | 9 months ago | |
| githttp.go | 8 months ago | |
| goget.go | 1 year ago | |
| home.go | 12 months ago | |
| metrics.go | 2 years ago | |
| nodeinfo.go | 1 year ago | |
| passkey.go | 1 year ago | |
| swagger_json.go | 1 year ago | |
| web.go | 7 months ago | |
| webfinger.go | 1 year ago | |