You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/modules/setting
wxiaoguang b4460cf541
Make "install page" respect environment config (#25648) (#25799)
Backport #25648

Replace #25580

Fix #19453

The problem was: when users set "GITEA__XXX__YYY" , the "install page"
doesn't respect it.

So, to make the result consistent and avoid surprising end users, now
the "install page" also writes the environment variables to the config
file.

And, to make things clear, there are enough messages on the UI to tell
users what will happen.

There are some necessary/related changes to `environment-to-ini.go`:

* The "--clear" flag is removed and it was incorrectly written there.
The "clear" operation should be done if INSTALL_LOCK=true
* The "--prefix" flag is removed because it's never used, never
documented and it only causes inconsistent behavior.

The only conflict during backport is "ui divider" in
templates/install.tmpl
2 years ago
..
actions.go Restrict `[actions].DEFAULT_ACTIONS_URL` to only `github` or `self` (#25581) (#25604) 2 years ago
actions_test.go Restrict `[actions].DEFAULT_ACTIONS_URL` to only `github` or `self` (#25581) (#25604) 2 years ago
admin.go Refactor the setting to make unit test easier (#22405) 2 years ago
api.go Refactor the setting to make unit test easier (#22405) 2 years ago
asset_dynamic.go Use a general approach to access custom/static/builtin assets (#24022) 2 years ago
asset_static.go Use a general approach to access custom/static/builtin assets (#24022) 2 years ago
attachment.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
attachment_test.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
cache.go Refactor the setting to make unit test easier (#22405) 2 years ago
camo.go Refactor the setting to make unit test easier (#22405) 2 years ago
config_env.go Make "install page" respect environment config (#25648) (#25799) 2 years ago
config_env_test.go Make "install page" respect environment config (#25648) (#25799) 2 years ago
config_provider.go Refactor path & config system (#25330) (#25416) 2 years ago
config_provider_test.go Refactor path & config system (#25330) (#25416) 2 years ago
cors.go Fix incorrect CORS default values (#24206) 2 years ago
cron.go Replace `interface{}` with `any` (#25686) (#25687) 2 years ago
cron_test.go Rewrite queue (#24505) 2 years ago
database.go Use "utf8mb4" for MySQL by default (#25432) 2 years ago
database_sqlite.go Implement FSFE REUSE for golang files (#21840) 2 years ago
database_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
federation.go Refactor the setting to make unit test easier (#22405) 2 years ago
git.go Use `[git.config]` for reflog cleaning up (#24958) 2 years ago
git_test.go Use `[git.config]` for reflog cleaning up (#24958) 2 years ago
highlight.go Refactor the setting to make unit test easier (#22405) 2 years ago
i18n.go Refactor the setting to make unit test easier (#22405) 2 years ago
incoming_email.go Refactor the setting to make unit test easier (#22405) 2 years ago
indexer.go Allow skipping forks and mirrors from being indexed (#23187) 2 years ago
indexer_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
lfs.go Avoid polluting config file when "save" (#25395) (#25406) 2 years ago
lfs_test.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
log.go Fix sub-command log level (#25537) (#25553) 2 years ago
log_test.go Replace `interface{}` with `any` (#25686) (#25687) 2 years ago
mailer.go Make mailer SMTP check have timed context (#24751) 2 years ago
mailer_test.go Remove unnecessary code (#24610) 2 years ago
markup.go Add .livemd as a markdown extension (#22730) 2 years ago
metrics.go Refactor the setting to make unit test easier (#22405) 2 years ago
migrations.go Refactor the setting to make unit test easier (#22405) 2 years ago
mime_type_map.go Refactor the setting to make unit test easier (#22405) 2 years ago
mirror.go Avoid polluting the config (#25345) (#25354) 2 years ago
oauth2.go Do not prepare oauth2 config if it is not enabled, do not write config in some sub-commands (#25567) (#25576) 2 years ago
other.go Refactor `setting.Other` and remove unused `SHOW_FOOTER_BRANDING` (#24270) 2 years ago
packages.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
packages_test.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
path.go Make "install page" respect environment config (#25648) (#25799) 2 years ago
path_test.go Refactor path & config system (#25330) (#25416) 2 years ago
picture.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
project.go Refactor the setting to make unit test easier (#22405) 2 years ago
proxy.go Refactor the setting to make unit test easier (#22405) 2 years ago
queue.go Rewrite queue (#24505) 2 years ago
repository.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
repository_archive.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
repository_archive_test.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
security.go Make "install page" respect environment config (#25648) (#25799) 2 years ago
server.go Refactor path & config system (#25330) (#25416) 2 years ago
service.go Support wildcard in email domain allow/block list (#24831) 2 years ago
service_test.go Support wildcard in email domain allow/block list (#24831) 2 years ago
session.go Refactor cookie (#24107) 2 years ago
setting.go Make "install page" respect environment config (#25648) (#25799) 2 years ago
setting_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
ssh.go Prefer native parser for SSH public key parsing (#23798) 2 years ago
storage.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
storage_test.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2 years ago
task.go handle deprecated settings (#22992) 2 years ago
time.go Remove unused setting `time.FORMAT` (#24430) 2 years ago
ui.go Remove the service worker (#25010) 2 years ago
webhook.go Refactor the setting to make unit test easier (#22405) 2 years ago