github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/build
History
KN4CK3R cd78c30fd3
Use filename as id/class prefix. () 
Currently the svg minifier (`make svg`) rewrites all `id` and `class` attributes in svg files. Every file gets the ids `a, b, ...`. If multiple svgs with ids are used on a page these ids are conflicting and the results are broken images.

| minified ids | unique ids |
| - | - |
| ![grafik](https://user-images.githubusercontent.com/1666336/132579375-59d3996f-c4e5-43b8-8c8d-82280c90d9e3.png) | ![grafik](https://user-images.githubusercontent.com/1666336/132579413-05bf9285-4e3b-4d0d-8f95-90b212405b05.png) |

This PR adds a prefix (the filename) to every id/class.

Follow up problem: Because we embed svg images there are duplicated ids if one svg image is used multiple times on a page. As those ids refer to the same content it may be no real problem because browser handle that fine.
..
generate-bindata.go Add bundle download for repository ()
generate-emoji.go Add bundle download for repository ()
generate-gitignores.go Add bundle download for repository ()
generate-images.js Make build scripts compatible with node 12 ()
generate-licenses.go Add bundle download for repository ()
generate-svg.js Use filename as id/class prefix. ()
gocovmerge.go Enable race detector for CI ()
update-locales.sh Format files ()