You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/web_src/js/features
zeripath 72fa108cbc
Fix review excerpt (#18502) (#18530)
Backport #18502

Currently the "File Changed" tab of a PR is somehow broken. This is also true for the current release 1.16.0.

When you are on the "File Changed" tab, and want to look at code excerpt before or after the code changes, the layout breaks. You can test this on try.gitea.io here: https://try.gitea.io/testnotexisting/magic_enum/pulls/2/files

The problem occurs for the unified view and for the split view.

Kind of the same problem was there for commenting a line of code, this was fixed in #18321 and #18403.

For consistency, I changed the solution of #18321, I removed the ``colspan`` and instead added a ``<td>``. The goal was to have code similarly with the split view.

Also the separator line in the split view was in the wrong column, this was fixed too.* more consistent unified review comment

Fix #18516

Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: confusedsushi <confused.sushi@googlemail.com>
3 years ago
..
comp Make the height of the editor in Review Box smaller (4 lines as GitHub) (#18319) 3 years ago
admin-common.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 3 years ago
admin-emails.js Split `index.js` to separate files (#17315) 3 years ago
admin-users.js Frontend refactor: move Vue related code from `index.js` to `components` dir, and remove unused codes. (#17301) 3 years ago
clipboard.js Add new JS linter rules (#17699) 3 years ago
codeeditor.js Add new JS linter rules (#17699) 3 years ago
colorpicker.js Move jquery-minicolors to npm/webpack (#12305) 5 years ago
common-global.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 3 years ago
common-issue.js Update JS dependencies, adjust eslint config (#17904) 3 years ago
common-organization.js Split `index.js` to separate files (#17315) 3 years ago
contextpopup.js Fix context popup error (#17398) 3 years ago
dropzone.js Update JS dependencies (#17611) 3 years ago
emoji.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 3 years ago
eventsource.sharedworker.js Update JS dependencies (#16708) 4 years ago
heatmap.js Add new JS linter rules (#17699) 3 years ago
imagediff.js Improve async/await usage, and sort init calls in `index.js` (#17386) 3 years ago
install.js Refactor install page (db type) (#17919) 3 years ago
notification.js Fix some incorrect async functions, improve frontend document. (#17597) 3 years ago
org-team.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 3 years ago
repo-branch.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 3 years ago
repo-code.js Add new JS linter rules (#17699) 3 years ago
repo-commit.js Improve ellipsis buttons (#17773) 3 years ago
repo-common.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 3 years ago
repo-diff.js Fix PR comments UI (#18323) 3 years ago
repo-editor.js Sanitize user-input on file name (#17666) 3 years ago
repo-graph.js Fix some incorrect async functions, improve frontend document. (#17597) 3 years ago
repo-home.js Add new JS linter rules (#17699) 3 years ago
repo-issue-content.js Fix PR comments UI (#18323) 3 years ago
repo-issue.js Fix review excerpt (#18502) (#18530) 3 years ago
repo-legacy.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 3 years ago
repo-migrate.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 3 years ago
repo-migration.js Improve async/await usage, and sort init calls in `index.js` (#17386) 3 years ago
repo-projects.js Support sorting for project board issuses (#17152) 3 years ago
repo-release.js Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE (#18069) 3 years ago
repo-settings.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 3 years ago
repo-template.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 3 years ago
repo-unicode-escape.js Add warning for BIDI characters in page renders and in diffs (#17562) 3 years ago
repo-wiki.js Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE (#18069) 3 years ago
serviceworker.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 3 years ago
sshkey-helper.js Split `index.js` to separate files (#17315) 3 years ago
stopwatch.js Fix some incorrect async functions, improve frontend document. (#17597) 3 years ago
tablesort.js Added missing `data-` prefix. (#17884) 3 years ago
tribute.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 3 years ago
user-auth-webauthn.js Prevent showing webauthn error for every time visiting `/user/settings/security` (#18385) (#18386) 3 years ago
user-auth.js Split `index.js` to separate files (#17315) 3 years ago
user-settings.js Split `index.js` to separate files (#17315) 3 years ago