You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/web/repo
Markus Amshove a11ccc9fcd
Disallow merge when required checked are missing (#29143)
fixes #21892 

This PR disallows merging a PR when not all commit status contexts
configured in the branch protection are met.

Previously, the PR was happy to merge when one commit status was
successful and the other contexts weren't reported.

Any feedback is welcome, first time Go :-)
I'm also not sure if the changes in the template break something else

Given the following branch protection:


![branch_protection](https://github.com/go-gitea/gitea/assets/2401875/f871b4e4-138b-435a-b496-f9ad432e3dec)

This was shown before the change:


![before](https://github.com/go-gitea/gitea/assets/2401875/60424ff0-ee09-4fa0-856e-64e6e3fb0612)

With the change, it is now shown as this:


![after](https://github.com/go-gitea/gitea/assets/2401875/4e464142-efb1-4889-8166-eb3be26c8f3d)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
12 months ago
..
actions Artifact deletion in actions ui (#27172) 12 months ago
setting Change webhook-type in create-view (#29114) 12 months ago
activity.go Implement contributors graph (#27882) 12 months ago
attachment.go Even more `db.DefaultContext` refactor (#27352) 1 year ago
blame.go Extract linguist code to method (#29168) 12 months ago
branch.go Adjust object format interface (#28469) 1 year ago
cherry_pick.go Refactor locale&string&template related code (#29165) 12 months ago
commit.go Simplify how git repositories are opened (#28937) 1 year ago
compare.go Refactor locale&string&template related code (#29165) 12 months ago
contributors.go Implement contributors graph (#27882) 12 months ago
download.go Less naked returns (#25713) 2 years ago
editor.go Refactor locale&string&template related code (#29165) 12 months ago
editor_test.go Simplify how git repositories are opened (#28937) 1 year ago
find.go Implement FSFE REUSE for golang files (#21840) 2 years ago
githttp.go Some refactor for git http (#28995) 1 year ago
githttp_test.go Fix http protocol auth (#27875) 1 year ago
helper.go Improve tree not found page (#26570) 1 year ago
helper_test.go Make web context initialize correctly for different cases (#26726) 1 year ago
issue.go Refactor locale&string&template related code (#29165) 12 months ago
issue_content_history.go Refactor locale&string&template related code (#29165) 12 months ago
issue_dependency.go Upgrade to golangci-lint@v1.55.0 (#27756) 1 year ago
issue_label.go Even more `db.DefaultContext` refactor (#27352) 1 year ago
issue_label_test.go Refactor locale&string&template related code (#29165) 12 months ago
issue_lock.go Penultimate round of `db.DefaultContext` refactor (#27414) 1 year ago
issue_pin.go Fix missing check (#28406) 1 year ago
issue_stopwatch.go Final round of `db.DefaultContext` refactor (#27587) 1 year ago
issue_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
issue_timetrack.go Final round of `db.DefaultContext` refactor (#27587) 1 year ago
issue_watch.go Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (#28908) 1 year ago
main_test.go make writing main test easier (#27270) 1 year ago
middlewares.go Improve user experience for outdated comments (#29050) 1 year ago
migrate.go Next round of `db.DefaultContext` refactor (#27089) 1 year ago
milestone.go Refactor issue template parsing and fix API endpoint (#29069) 12 months ago
packages.go Fix the display of org level badges (#26504) 1 year ago
patch.go Refactor locale&string&template related code (#29165) 12 months ago
projects.go Refactor locale&string&template related code (#29165) 12 months ago
projects_test.go Move web/api context related testing function into a separate package (#26859) 1 year ago
pull.go Disallow merge when required checked are missing (#29143) 12 months ago
pull_review.go Load outdated comments when (un)resolving conversation on PR timeline (#29203) 12 months ago
pull_review_test.go Load outdated comments when (un)resolving conversation on PR timeline (#29203) 12 months ago
release.go Rework markup link rendering (#26745) 1 year ago
release_test.go Move more functions to db.Find (#28419) 1 year ago
render.go Preserve BOM in web editor (#28935) 1 year ago
repo.go Don't do a full page load when clicking `Watch` or `Star` (#29001) 1 year ago
search.go Refactor indexer (#25174) 2 years ago
topic.go Next round of `db.DefaultContext` refactor (#27089) 1 year ago
treelist.go Implement FSFE REUSE for golang files (#21840) 2 years ago
view.go Refactor locale&string&template related code (#29165) 12 months ago
view_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
wiki.go Refactor locale&string&template related code (#29165) 12 months ago
wiki_test.go Simplify how git repositories are opened (#28937) 1 year ago