You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/modules/markup
Yarden Shoham b5c418f271
Don't use `<br />` in alert block (#29650)
- Follows https://github.com/go-gitea/gitea/pull/29121

When I implemented alert blocks I was always testing the markdown in
issue comments. I used `<br />` for line breaks and it looked good. I
have since learned that the markdown on README files doesn't allow these
tags. So a comment with

```md
> [!NOTE]
> If you're interested in using our APIs, we have experimental support with [documentation](https://try.gitea.io/api/swagger).
```

looked like this in a comment

![image](https://github.com/go-gitea/gitea/assets/20454870/96b1de01-2c87-4d4f-83dd-98192b83e9d0)
but looked like this in a README

![image](https://github.com/go-gitea/gitea/assets/20454870/474b636d-dd7a-4b7f-ba27-643803c71aa3)

So I changed how we render the alert block by having the alert itself
have a dedicated paragraph, so line breaks happen naturally between
paragraphs.

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/474b636d-dd7a-4b7f-ba27-643803c71aa3)

![image](https://github.com/go-gitea/gitea/assets/20454870/167a8d37-9a44-4479-9340-5dc80347b595)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/2f99fec0-98ff-4ba8-97fe-b4567041ae79)

![image](https://github.com/go-gitea/gitea/assets/20454870/ffdeae11-fb06-4d00-b497-eae135f0d7ad)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
11 months ago
..
asciicast Support asciicast files as new markup (#22448) 2 years ago
common Make `user-content-* ` consistent with github (#26388) 2 years ago
console Add context when rendering labels or emojis (#23281) 2 years ago
csv Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize (#29653) 11 months ago
external Rework markup link rendering (#26745) 1 year ago
markdown Don't use `<br />` in alert block (#29650) 11 months ago
mdstripper Implement FSFE REUSE for golang files (#21840) 2 years ago
orgmode Refactor markup rendering to accept general "protocol:" prefix (#29276) 12 months ago
camo.go Implement FSFE REUSE for golang files (#21840) 2 years ago
camo_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
html.go Refactor markup rendering to accept general "protocol:" prefix (#29276) 12 months ago
html_internal_test.go Add support for sha256 repositories (#23894) 1 year ago
html_test.go Refactor some Str2html code (#29397) 11 months ago
renderer.go Rework markup link rendering (#26745) 1 year ago
renderer_test.go Move `IsReadmeFile*` from `modules/markup/` to `modules/util` (#22877) 2 years ago
sanitizer.go Add alert blocks in markdown (#29121) 1 year ago
sanitizer_test.go Use restricted sanitizer for repository description (#28141) 1 year ago