You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/auth
Lunny Xiao 900e158064
refactor auth interface to return error when verify failure (#22119) (#22259)
backport #22119

This PR changed the Auth interface signature from `Verify(http
*http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2 years ago
..
source Revert unrelated changes for SMTP auth (#21767) (#21768) 2 years ago
auth.go Remove dependent on session auth for api/v1 routers (#19321) 3 years ago
auth_test.go format with gofumpt (#18184) 3 years ago
basic.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
group.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
httpsign.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
interface.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
oauth2.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
reverseproxy.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
session.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
signin.go Restore user autoregistration with email addresses (#19261) 3 years ago
source.go Refactor auth package (#17962) 3 years ago
sspi_windows.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
sync.go Refactor auth package (#17962) 3 years ago