You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
sillyguodong
bfecf3bd89
Fix internal sever error when visiting a PR that bound to the deleted team ( #24127 )
...
Close : #23738
The actual cause of `500 Internal Server Error` in the issue is not what
is descirbed in the issue.
The actual cause is that after deleting team, if there is a PR which has
requested reivew from the deleted team, the comment could not match with
the deleted team by `assgin_team_id`. So the value of `.AssigneeTeam`
(see below code block) is `nil` which cause `500 error`.
1c8bc4081a/templates/repo/issue/view_content/comments.tmpl (L691-L695)
To fix this bug, there are the following problems to be resolved:
- [x] 1. ~~Stroe the name of the team in `content` column when inserting
`comment` into DB in case that we cannot get the name of team after it
is deleted. But for comments that already exist, just display "Unknown
Team"~~ Just display "Ghost Team" in the comment if the assgined team is
deleted.
- [x] 2. Delete the PR&team binding (the row of which `review_team_id =
${team_id} ` in table `review`) when deleting team.
- [x] 3.For already exist and undeleted binding rows in in table
`review`, ~~we can delete these rows when executing migrations.~~ they
do not affect the function, so won't delete them.
2 years ago
..
actions
Add runner check in repo action page ( #24124 )
2 years ago
branch
Use a general Eval function for expressions in templates. ( #23927 )
2 years ago
cite
Use data-tooltip-content for tippy tooltip ( #23649 )
2 years ago
diff
Expand/Collapse all changed files ( #23639 )
2 years ago
editor
Allow adding new files to an empty repo ( #24164 )
2 years ago
find
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
graph
Use a general Eval function for expressions in templates. ( #23927 )
2 years ago
issue
Fix internal sever error when visiting a PR that bound to the deleted team ( #24127 )
2 years ago
migrate
Group template helper functions, remove `Printf`, improve template error messages ( #23982 )
2 years ago
projects
Add unset default project column ( #23531 )
2 years ago
pulls
Discolor pull request tab labels ( #23950 )
2 years ago
release
Refactor locale number ( #24134 )
2 years ago
settings
Use auto-updating, natively hoverable, localized time elements ( #23988 )
2 years ago
wiki
Make wiki title supports dashes and improve wiki name related features ( #24143 )
2 years ago
activity.tmpl
Use auto-updating, natively hoverable, localized time elements ( #23988 )
2 years ago
blame.tmpl
Use data-tooltip-content for tippy tooltip ( #23649 )
2 years ago
branch_dropdown.tmpl
Refactor branch/tag selector to Vue SFC ( #23421 )
2 years ago
clone_buttons.tmpl
Clean template/helper.go ( #23922 )
2 years ago
clone_script.tmpl
Clean template/helper.go ( #23922 )
2 years ago
commit_page.tmpl
Remove incorrect HTML self close tag ( #23748 )
2 years ago
commit_status.tmpl
Use different SVG for pending and running actions ( #23836 )
2 years ago
commit_statuses.tmpl
Fix hidden commit status on multiple checks ( #22889 )
2 years ago
commits.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
commits_list.tmpl
Add context when rendering labels or emojis ( #23281 )
2 years ago
commits_list_small.tmpl
Use a general Eval function for expressions in templates. ( #23927 )
2 years ago
commits_table.tmpl
Use data-tooltip-content for tippy tooltip ( #23649 )
2 years ago
create.tmpl
Make label templates have consistent behavior and priority ( #23749 )
2 years ago
create_helper.tmpl
Add templates to customize text when creating and migrating repositories
2 years ago
empty.tmpl
Allow adding new files to an empty repo ( #24164 )
2 years ago
file_info.tmpl
Use data-tooltip-content for tippy tooltip ( #23649 )
2 years ago
forks.tmpl
Remove fomantic ".link" selector and styles ( #23888 )
2 years ago
graph.tmpl
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none ( #22950 )
2 years ago
header.tmpl
Use data-tooltip-content for tippy tooltip ( #23649 )
2 years ago
home.tmpl
Allow adding new files to an empty repo ( #24164 )
2 years ago
icon.tmpl
Move helpers to be prefixed with `gt-` ( #22879 )
2 years ago
packages.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago
search.tmpl
Use data-tooltip-content for tippy tooltip ( #23649 )
2 years ago
search_name.tmpl
Clean template/helper.go ( #23922 )
2 years ago
shabox_badge.tmpl
Fix shabox regression ( #22924 )
2 years ago
sub_menu.tmpl
Refactor locale number ( #24134 )
2 years ago
unicode_escape_prompt.tmpl
Convert `<div class="button">` to `<button class="button">` ( #23337 )
2 years ago
upload.tmpl
Refactor `i18n` to `locale` ( #20153 )
3 years ago
user_cards.tmpl
Use auto-updating, natively hoverable, localized time elements ( #23988 )
2 years ago
view_file.tmpl
Use a general Eval function for expressions in templates. ( #23927 )
2 years ago
view_list.tmpl
Add wrapper to author to avoid long name ui problem ( #23030 )
2 years ago
watchers.tmpl
Add main landmark to templates and adjust titles ( #22670 )
2 years ago