You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services
Eng Zer Jun 8b0aaa5f86
test: use `T.TempDir` to create temporary test directory (#21043)
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2 years ago
..
agit Add more linters to improve code readability (#19989) 3 years ago
asymkey Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
attachment Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
auth Share HTML template renderers and create a watcher framework (#20218) 2 years ago
automerge Add more linters to improve code readability (#19989) 3 years ago
comments Move issues related files into models/issues (#19931) 3 years ago
context Move almost all functions' parameter db.Engine to context.Context (#19748) 3 years ago
cron Move some files into models' sub packages (#20262) 2 years ago
externalaccount Refactor auth package (#17962) 3 years ago
forms refactor webhook *NewPost (#20729) 3 years ago
gitdiff Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
issue Move some files into models' sub packages (#20262) 2 years ago
lfs Move some code into models/git (#19879) 3 years ago
mailer Share HTML template renderers and create a watcher framework (#20218) 2 years ago
migrations Add more checks in migration code (#21011) 2 years ago
mirror Add new API endpoints for push mirrors management (#19841) 3 years ago
org Move some files into models' sub packages (#20262) 2 years ago
packages Replace `ServeStream` with `ServeContent` (#20903) 2 years ago
pull Prevent 500 is head repo does not have PullRequest unit in IsUserAllowedToUpdate (#20839) 2 years ago
release Add more checks in migration code (#21011) 2 years ago
repository fix hard-coded timeout and error panic in API archive download endpoint (#20925) 2 years ago
task Move some files into models' sub packages (#20262) 2 years ago
user Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
webhook Update a few go dependencies (#21022) 2 years ago
wiki test: use `T.TempDir` to create temporary test directory (#21043) 2 years ago