You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/modules/context
Lunny Xiao 900e158064
refactor auth interface to return error when verify failure (#22119) (#22259)
backport #22119

This PR changed the Auth interface signature from `Verify(http
*http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2 years ago
..
access_log.go Pass down SignedUserName down to AccessLogger context (#16605) 4 years ago
api.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
api_org.go Move organization related structs into sub package (#18518) 3 years ago
api_test.go format with gofumpt (#18184) 3 years ago
auth.go Respond with a 401 on git push when password isn't changed yet (#20026) 3 years ago
captcha.go format with gofumpt (#18184) 3 years ago
context.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
csrf.go Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (#19337) 3 years ago
form.go Add config options to hide issue events (#17414) 3 years ago
org.go Add user/organization code search (#19977) 2 years ago
package.go Fix package access for admins and inactive users (#21580) 2 years ago
pagination.go Remove tab/TabName usage where it's not needed (#19973) 3 years ago
permission.go Move access and repo permission to models/perm/access (#19350) 3 years ago
private.go Add more linters to improve code readability (#19989) 3 years ago
repo.go Use complete SHA to create and query commit status (#22244) (#22257) 2 years ago
response.go format with gofumpt (#18184) 3 years ago
utils.go Add more linters to improve code readability (#19989) 3 years ago
xsrf.go Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (#19337) 3 years ago
xsrf_test.go Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (#19337) 3 years ago