You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

History

Kirill Bolashev 4938945668 Handle files starting with colons in WalkGitLog (#22935 ) Currently gitea shows no commit information for files starting with a colon. [I set up a minimal repro repository that reproduces this error once it's migrated on gitea](https://github.com/kbolashev/colon-test) <img width="1209" alt="image" src="https://user-images.githubusercontent.com/111061261/219326625-0e6d3a86-8b58-4d67-bc24-8a78963f36b9.png"> This is happening because the filenames piped to the `git log` command are written as is, and it doesn't work when you have a colon at the start of the filename, and you need to escape it. You can test it locally, if you do ``` mkdir repo git init touch :file git add . && git commit -m "Add file with colon" git log -- :file ``` git log returns nothing. However, if you do `git log -- "\:file"`, it will show the commit with the file change. This PR escapes the starting colons in paths in the `LogNameStatusRepo` function, making gitea return commit info about the file with the bad filename. <img width="1209" alt="image" src="https://user-images.githubusercontent.com/111061261/219328299-46451246-4006-45e3-89b1-c244635ded23.png"> This error shows up only with files starting with colon, anywhere else in filename is ok. Dashes at the beginning also seem to be working. I don't know gitea internals well enough to know where else this error can pop up, so I'm keeping this PR small as suggested by your contributor guide		2 years ago
..
foreachref	Implement FSFE REUSE for golang files (#21840 )	2 years ago
internal	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
pipeline	Refactor and tidy-up the merge/update branch code (#22568 )	2 years ago
tests/repos	Fix commit retrieval by tag (#21804 )	2 years ago
url	Implement FSFE REUSE for golang files (#21840 )	2 years ago
README.md	move code.gitea.io/git to code.gitea.io/gitea/modules/git (#6364 )	6 years ago
batch_reader.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
blame.go	Fix blame view missing lines (#22826 )	2 years ago
blame_test.go	Fix blame view missing lines (#22826 )	2 years ago
blob.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
blob_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
blob_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
blob_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
command.go	Refactor merge/update git command calls (#23366 )	2 years ago
command_race_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
command_test.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
commit.go	Fix pull request update showing too many commits with multiple branches (#22856 )	2 years ago
commit_convert_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
commit_info.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
commit_info_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
commit_info_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
commit_info_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
commit_reader.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
commit_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
diff.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
diff_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
error.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
git.go	Support reflogs (#22451 )	2 years ago
git_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
hook.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
last_commit_cache.go	Use minio/sha256-simd for accelerated SHA256 (#23052 )	2 years ago
last_commit_cache_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
last_commit_cache_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
log_name_status.go	Handle files starting with colons in WalkGitLog (#22935 )	2 years ago
notes.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
notes_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
notes_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
notes_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
parse_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
parse_gogit_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
parse_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
parse_nogogit_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
ref.go	Util type to parse ref name (#21969 )	2 years ago
remote.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo.go	Use proxy for pull mirror (#22771 )	2 years ago
repo_archive.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_attribute.go	Refactor legacy strange git operations (#22756 )	2 years ago
repo_attribute_test.go	Remove deadcode (#22245 )	2 years ago
repo_base.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_base_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_base_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_blame.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_blob.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_blob_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_blob_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_blob_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_branch.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_branch_gogit.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_branch_nogogit.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_branch_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_commit.go	Fix pull request update showing too many commits with multiple branches (#22856 )	2 years ago
repo_commit_gogit.go	Fix commit retrieval by tag (#21804 )	2 years ago
repo_commit_nogogit.go	Fix commit retrieval by tag (#21804 )	2 years ago
repo_commit_test.go	Fix commit retrieval by tag (#21804 )	2 years ago
repo_commitgraph.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_commitgraph_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_compare.go	Fix GetFilesChangedBetween if the file name may be escaped (#23272 )	2 years ago
repo_compare_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_gpg.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_hook.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_index.go	Use complete SHA to create and query commit status (#22244 )	2 years ago
repo_language_stats.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_language_stats_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_language_stats_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_language_stats_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_object.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_ref.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_ref_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_ref_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_ref_test.go	Fix commit retrieval by tag (#21804 )	2 years ago
repo_stats.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_stats_test.go	Fix commit retrieval by tag (#21804 )	2 years ago
repo_tag.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_tag_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repo_tag_nogogit.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_tag_test.go	Fix commit retrieval by tag (#21804 )	2 years ago
repo_test.go	Fix commit retrieval by tag (#21804 )	2 years ago
repo_tree.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
repo_tree_gogit.go	Use complete SHA to create and query commit status (#22244 )	2 years ago
repo_tree_nogogit.go	Use complete SHA to create and query commit status (#22244 )	2 years ago
sha1.go	Use complete SHA to create and query commit status (#22244 )	2 years ago
sha1_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
sha1_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
sha1_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
signature.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
signature_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
signature_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
submodule.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
submodule_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tag.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tag_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_blob.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_blob_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_blob_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_entry.go	Remember to attach the parent tree when converting TreeEntry() -> Tree() (#22902 )	2 years ago
tree_entry_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_entry_mode.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_entry_nogogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_entry_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_gogit.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
tree_nogogit.go	Refactor git command package to improve security and maintainability (#22678 )	2 years ago
utils.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago
utils_test.go	Implement FSFE REUSE for golang files (#21840 )	2 years ago

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.